Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site: Mobile navigation menu has no way to close #763

Closed
shoupeva-ithaka opened this issue May 29, 2024 · 1 comment · Fixed by #782
Closed

Site: Mobile navigation menu has no way to close #763

shoupeva-ithaka opened this issue May 29, 2024 · 1 comment · Fixed by #782

Comments

@shoupeva-ithaka
Copy link
Contributor

Expected behavior
The side navigation is hidden by default, a menu icon button is present to open the side navigation, and when it is open it has a close button on mobile.

Actual behavior
The side navigation component on mobile is open by default and has no close button.

Steps to reproduce the issue

  1. Go to https://pharos.jstor.org on a mobile device

Screenshots or code
image

Pharos version
N/A

Your environment

  • OS: M1 Pro Mac – Sonoma 14.2.1
  • Browser: Chrome / Safari

Additional information
The side navigation on mobile in the Safari browser also only expands to the navigation bar at the bottom (or the top as I believe that is a configurable setting). It can make for some wonky behavior. I wonder if it is also wise to have the side navigation height expand the entire height of the window instead of the viewport (then maybe an internal container element can only expand the height of the viewport for proper scroll behavior).

@daneah
Copy link
Member

daneah commented Jun 1, 2024

Likely introduced by #478 (see #417)

@daneah daneah changed the title Pharos site mobile navigation menu has no way to close Site: Mobile navigation menu has no way to close Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants