Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to static preview files #765

Open
daneah opened this issue Jun 3, 2024 · 0 comments
Open

Migrate to static preview files #765

daneah opened this issue Jun 3, 2024 · 0 comments
Labels
infrastructure storybook

Comments

@daneah
Copy link
Member

daneah commented Jun 3, 2024

The problem
Storybook prefers that the preview configuration files be statically-defined, because for some purposes they statically parse the file rather than depending on its runtime behavior (see storybookjs/storybook#27510 and storybookjs/storybook#27418 discussions, and output from the current build process on develop)

The solution
Remove the dynamic nature of each Storybook's preview.ts file, or create a pre-Storybook build step that transforms the dynamic contents into static ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure storybook
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daneah