Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder icon and update image card and collection card placeholder state #774

Open
fswlee opened this issue Jun 27, 2024 · 2 comments

Comments

@fswlee
Copy link

fswlee commented Jun 27, 2024

At present, when there is no image available for an image card or a collection card, we show a grey background with an information icon and a message "Image preview not available". See image card and collection card.

We want to make several updates:

  1. add the placeholder image as an icon
  2. the state of the card should be called something like a 'placeholder' state rather than an error state
  3. we want to use a placeholder image to better communicate the issue at hand for the user--that there is no image at present.
placeholder card examples

3a. the placeholder image should be vertically and horizontally aligned within the square
3b. the small version of the image should be used for the image card (48 width) and the large for the collection card (64 width). I've supplied versions in both sizes

PlaceholderSmall
PlaceholderLarge

@daneah
Copy link
Member

daneah commented Jun 27, 2024

@fswlee does it make sense to add the placeholder as part of the system iconography instead?

@fswlee
Copy link
Author

fswlee commented Aug 5, 2024

sorry i missed this @daneah -- I didn't see the notification email. I think that would make sense. That seems like the best place for the placeholder image to sit within the system

@fswlee fswlee changed the title Update image card and collection card placeholder state Add placeholder icon and update image card and collection card placeholder state Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants