Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCSS deprecation warnings #783

Open
daneah opened this issue Jul 22, 2024 · 0 comments
Open

Fix SCSS deprecation warnings #783

daneah opened this issue Jul 22, 2024 · 0 comments

Comments

@daneah
Copy link
Member

daneah commented Jul 22, 2024

The problem

On the latest version of sass, we now get deprecation warnings about certain syntax that is quite present in the code base:

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

The solution

Update syntax to fix warnings. Either of the suggested approaches in the warning should be amenable in our code, but may need case-by-case consideration for which is more readable and so on. In very rare cases, changes may create a specificity issue—we should lean on Chromatic to let us know.

Additional information

Sass docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant