Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have option to remove the overlay from the primary(red) loading spinner #814

Open
michael-iden opened this issue Sep 16, 2024 · 1 comment

Comments

@michael-iden
Copy link
Contributor

michael-iden commented Sep 16, 2024

The problem
We are considering putting loading spinners on secondary buttons as an indication that the user action from the click is happening for certain workflows. We have a small loading spinner that works well in a button but it applies an overlay internally to the button but not the button padding that looks rather strange. We also have an "on background" loading spinner that does remove the overlay but the spinner portion itself is white, which won't be visible on a secondary button.

The solution
Create a property to remove the semi-transparent overlay from the primary red loading spinner

Alternatives considered
Use other button types such as primary.

Additional information
Current UX with a loading spinner on a disabled secondary button
image

@daneah
Copy link
Member

daneah commented Sep 16, 2024

In my view this might stretch the intended use case of the loading spinner as-designed. If we intend to extend to these hyper-focused uses, we might consider doing a broader revisit to ensure the design is as supportive as it can be (vs. e.g. adding a no-overlay prop or something)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants