Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add Description List Component #835

Open
joiechang opened this issue Nov 21, 2024 · 0 comments
Open

Storybook: Add Description List Component #835

joiechang opened this issue Nov 21, 2024 · 0 comments

Comments

@joiechang
Copy link

The problem
Currently our metadata on JSTOR and Odyssey are snowflake components even though they are performing the same function (showing metadata about an item).

The solution
I'd like for us to use Description Lists for these components moving forward, so we can have the same styling and improve accessibility on pages with metadata. It'd be useful to have the default styling for the Description Terms <dt> and Description Term Description <dd>, but with the possibility of overriding the styling if necessary.

Image

Alternatives considered

  • Styling with headers and plain text

Additional information
Link to Pharos UI Kit: https://www.figma.com/design/sPvnmrxhsJpQqMYrQKwXve/Pharos-UI-Kit?node-id=20114-70243&t=q1fwGei5bMsuAF4p-4
Test Codepen: https://codepen.io/Joie-Chang/pen/WNVdvbe
A11Y Style Guide: https://a11y-style-guide.com/style-guide/section-structure.html#kssref-structure-lists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant