Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGs are not linted during the pre-commit checks #872

Open
brentswisher opened this issue Feb 4, 2025 · 0 comments
Open

SVGs are not linted during the pre-commit checks #872

brentswisher opened this issue Feb 4, 2025 · 0 comments

Comments

@brentswisher
Copy link
Contributor

Expected behavior
When I commit changes to svg file to the project, the pre-commit hooks that run properly lint it using svglint.

Actual behavior
Linting of svg files does not happen during the pre-commit stage, but running yarn lint manually does properly lint the svg files.

Steps to reproduce the issue

  1. Change an svg with an invalid property, like adding fill="black" to one of the icon svgs
  2. Stage and start committing the change
  3. See that the error is not reported
  4. Run yarn lint
  5. See that the error is reported

Pharos version
14.7.0

Your environment

  • OS: macOS
  • Browser: N/A
  • Version: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants