Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][CI] ir_attachment_url: request for unittests #509

Open
iledarn opened this issue Dec 14, 2017 · 1 comment
Open

[11.0][CI] ir_attachment_url: request for unittests #509

iledarn opened this issue Dec 14, 2017 · 1 comment

Comments

@iledarn
Copy link

iledarn commented Dec 14, 2017

The 11.0 branch's ir_attachment_url module should have phantom_js tests
https://github.com/it-projects-llc/misc-addons/tree/11.0/ir_attachment_url

Thorough specification of the task is the following:
  • We should have a tour named 'product_add_url_image' - see the examples of how to make tours in the addons/website_sale/static/src/js/website_sale_tour_buy.js of odoo comunity 11.0.
  • The steps should correspond usage documentation of the ir_attachment_url. I.e.:
    • Go to Settings >> Users >> Users menu
    • Open the Administrator user's view form
    • Click [Edit] button
    • On the image field see the @ button - click it and specify valid url of image
    • Save the changes
    • Check binary image field's url on backend page (it will not be the same as you specify - and this is normal) that it actually points on the image - we had an issue that another module was messing up the binary image fields data
  • Then we should have js test with phantom_js using the tour
  • Python test - after self.phantom_js(... - in the same test method, find the image binary field attachment record (in the ir.attachment model) and check if the type field is equal to url and data field contains your url
Additional information

Instructions about odoo js tour and phantom js can be found here https://odoo-development.readthedocs.io/en/latest/qa/js/index.html

Python tests instruction is here https://odoo-development.readthedocs.io/en/latest/qa/python/index.html


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@yelizariev yelizariev changed the title 'ir_attachment_url' module requires js-tests [11.0][CI] ir_attachment_url: requests for unittests Dec 14, 2017
@yelizariev yelizariev changed the title [11.0][CI] ir_attachment_url: requests for unittests [11.0][CI] ir_attachment_url: request for unittests Dec 14, 2017
@yelizariev
Copy link
Collaborator

This test has to be postponed until we update travis and add the module to --load parameter there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants