Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't back when video Url error on IOS #109

Closed
hungdev opened this issue Jul 21, 2018 · 8 comments
Closed

Can't back when video Url error on IOS #109

hungdev opened this issue Jul 21, 2018 · 8 comments

Comments

@hungdev
Copy link

hungdev commented Jul 21, 2018

With Android, it works perfectly. But on Ios, with correct video url it can back. If the video url error, it can not back. Please look at the gif.
ev2

My code:

          <VideoPlayer
            source={{ uri: movieSelected }}
            controlTimeout={10000}
            navigator={this.props.navigation}
            onEnterFullscreen={Orientation.lockToLandscape}
            onExitFullscreen={Orientation.lockToPortrait}
            onError={(err) => this.showMessageBar()}
            onBack={() => this.onBackMovie()}
          />
  onBackMovie() {
    this.props.navigation.goBack()
    Orientation.lockToPortrait()
  }

thank you.

@hungdev hungdev changed the title Can't back with onback props on IOS Can't back when video Url error on IOS Jul 21, 2018
@hungdev
Copy link
Author

hungdev commented Aug 7, 2018

@kylemilloy could you help me?

@hungdev
Copy link
Author

hungdev commented Aug 10, 2018

i found the issue. it conflicts with react-native-flash-message lib.

@hungdev hungdev closed this as completed Aug 10, 2018
@hungdev hungdev reopened this Aug 11, 2018
@hungdev
Copy link
Author

hungdev commented Aug 11, 2018

It's not because of conflicts with react-native-flash-message, but because the onError function causes an error.

@thatjuan
Copy link

How did you fix this?

@hungdev
Copy link
Author

hungdev commented Aug 24, 2018

@thatjuan with ios: remove onError props. After that, you will get an error cant hide notification. You will need this code in the pull request #111

@thatjuan
Copy link

nicely done, thanks!

@kylemilloy
Copy link
Contributor

Sorry all...been away for a bit..I'll take a peek at your changes and merge them into the repo.

@zeroceus
Copy link

what kind of error did the onError function caused?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants