Change persistence.dataDir.storageClass to persistence.dataDir.storageClassName

[evilhamsterman]

The documentation in the values.yaml under persistence use the boilerplate text

minecraft-server-charts/charts/minecraft/values.yaml

Lines 271 to 285 in 30076e5

	persistence:
	annotations: {}
	## minecraft data Persistent Volume Storage Class
	## If defined, storageClassName: <storageClass>
	## If set to "-", storageClassName: "", which disables dynamic provisioning
	## If undefined (the default) or set to null, no storageClassName spec is
	## set, choosing the default provisioner. (gp2 on AWS, standard on
	## GKE, AWS & OpenStack)
	##
	# storageClass: "-"
	dataDir:
	# Set this to false if you don't care to persist state between restarts.
	enabled: false
	# existingClaim: nil
	Size: 1Gi

Which indicates that to use a storageClass you should use storageClassName. This is inline with many other charts and the value in a PVC definition. However the template uses storageClass instead of storageClassName. I didn't find this until I looked at the template itself and the deployment used a local-path instead of my specified storageclass

minecraft-server-charts/charts/minecraft/templates/datadir-pvc.yaml

Lines 26 to 30 in 30076e5

	{{- if .Values.persistence.storageClass }}
	{{- if (eq "-" .Values.persistence.storageClass) }}
	storageClassName: ""
	{{- else }}
	storageClassName: "{{ .Values.persistence.storageClass }}"

Either the documentation in README.md and the values.yaml should be updated, or better the general standard should be followed and use storageClassName

[itzg]

Thanks, yes that needs to be improved and I'm also leaning towards the standard naming.