Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video.captions camelCase vs snake_case #334

Open
iBicha opened this issue Jan 30, 2023 · 1 comment
Open

video.captions camelCase vs snake_case #334

iBicha opened this issue Jan 30, 2023 · 1 comment
Labels
question Further information is requested

Comments

@iBicha
Copy link
Contributor

iBicha commented Jan 30, 2023

I believe /API/V1/VIDEOS/:ID currently returns

  "captions": [
    {
      "label": String,
      "language_code": String,
      "url": String
    }
  ],

and not

  "captions": [
    {
      "label": String,
      "languageCode": String,
      "url": String
    }
  ],

Like the docs mention. There's a reference to both language_code and languageCode in the code which is a bit confusing.

@SamantazFox
Copy link
Member

Ah, thanks for pointing this out. It should have been LanguageCode, but it was changed here and was missed during the reviews: iv-org/invidious@35d15c7#diff-f8ae2508caf8eb3d260e47273d8b0d3d5b6b860c096d4b9fc9b2db12a323834aR429

I'll have to check with developers currently using the API if we change the code back, or if we keep the code as is and update the docs.

@unixfox unixfox added the question Further information is requested label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants