Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications installed via AM do not have icons. #561

Closed
musicfunfan opened this issue May 6, 2024 · 6 comments
Closed

Applications installed via AM do not have icons. #561

musicfunfan opened this issue May 6, 2024 · 6 comments

Comments

@musicfunfan
Copy link

Hello there. I use the AM package manager for some time now. And is working very good. The applications have a desktop entry on the application launcher (Rofi), but they do not have an icon.
Is it possible to display the icon of the application?

In this screenshot, i show the Joplin application installed via AM and not having the Joplin icon.

εικόνα

I did try the same thing on KDE 6 and its has icons. So this is probably my fault...

Any idea on how to fix it ?

I think i need to find where the icons has been stored. And create some symlink or ... add something on my PATH ? maybe ?

@Samueru-sama
Copy link
Contributor

Samueru-sama commented May 6, 2024

It's a bug on rofi that I reported and was fixed: davatorium/rofi#1977

You need to use rofi-git or compile from source. I have an appimage of rofi that is on am am -i rofi that is built from rofi-git and has the fix, however I haven't been able to figure out how to get rofi-emoji to work with it (If you don't use rofi-emoji then no problem).

Edit: I just checked your profile and you have a fork of rofi-emoji 🤣 in that case your only solution is to use rofi-git or compile rofi from source or wait for the next stable release of rofi.

@musicfunfan
Copy link
Author

I do not use regular Rofi. I use rofi-lbonn-wayland-git Because i am on Wayland and regular Rofi do not work well on Wayland. I use this fork for some time now and is fine.

I have a Rofi emoji fork. Because i wanted to make a PR. But now i do not remember what i wanted to add... But it was something in the documentation side. \

I also use flatpaks,snaps,arch packages and Rofi display the icons just fine... I do not know why appimages does not... I was thinking because the icons is not on the PATH or something of this nature.

@Samueru-sama
Copy link
Contributor

Samueru-sama commented May 6, 2024

I also use flatpaks,snaps,arch packages and Rofi display the icons just fine... I do not know why appimages does not... I was thinking because the icons is not on the PATH or something of this nature.

It's a bug on rofi that if the icon has a path and the image doesn't have .png or .svg on the name, it fails to display the image.

The bug was fixed once again, you would need to ask the fork you are using to apply the fix

You can also just go to the application and edit the image in the icons folder and add .png or .svg and edit the .desktop of the application to also add the extension and the issue gets fixed.

See I just installed rofi back:

rofi
image

rofi-git
image

@ivan-hc
Copy link
Owner

ivan-hc commented May 6, 2024

I can't reproduce the issue

Istantanea_2024-05-06_17-40-37 png

maybe it's your menu missing some specs

@Samueru-sama
Copy link
Contributor

Samueru-sama commented May 6, 2024

I can't reproduce the issue

The issue is when rofi is used as the application launcher, to do that run rofi -show drun -show-icons

However issue happens with the last stable release of rofi, which is version 1.7.5 which released in 2022, it was recently fixed like a month ago after I reported the issue, which I linked in my first comment here.

The rofi appimage is build by cloning the repo instead. So it has the fix and you will never see the issue.

If you want to reproduce the issue you would need to install rofi using your distros package manager and run rofi with rofi -show drun -show-icons and you will see that the apps installed by am have missing icons.

EDIT: If this isn't clear yet, this is not an issue with am but an issue with rofi that has been fixed, the problem is that rofi hasn't released a stable build that is fixed yet.

@musicfunfan
Copy link
Author

Yea i understand. Thank you @Samueru-sama. I see what i can do to fix it with the Wayland fork i use. So with this. I will close this issue because its not an issue with AM. But with Rofi. Thanks again for the info @Samueru-sama .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants