Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation and Conv order in Upsample module #24

Open
softrimewu opened this issue Jul 14, 2021 · 1 comment
Open

Interpolation and Conv order in Upsample module #24

softrimewu opened this issue Jul 14, 2021 · 1 comment

Comments

@softrimewu
Copy link

Hi,

I noticed that in upsampling block, the code does Conv1dWithInitialization and then InterpolationBlock.

code link

But in paper network structure it looks like the reverse order of yours.
image

Could you please confirm this?

Thanks

@ivanvovk
Copy link
Owner

@softrimewu Yes, I know about this issue. It's a bug, however, I can also confirm that it does not affect output quality (I have checked). Nonetheless, it will be fixed in a sooner update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants