Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong shift-placement in smithing table #22

Open
Rad586 opened this issue Mar 23, 2023 · 2 comments
Open

Wrong shift-placement in smithing table #22

Rad586 opened this issue Mar 23, 2023 · 2 comments
Labels
1.18.2 Issue happened in 1.18.2 fabric Fabric related suggestion New feature or request

Comments

@Rad586
Copy link
Contributor

Rad586 commented Mar 23, 2023

Describe the Bug

Shift-clicking the gold armor places it straightly into the ingot slot. This makes smithing in modpack, especially with custom smithing recipes kinda broken.

Reproduction Steps

  1. Place down a smithing table
  2. Shift click an armor besides a diamond one

Expected Result

Placed in the armor slot.

Screenshots and Videos

https://postimg.cc/mzb0Pr4d

Crash Report or Log

No response

Operating System

win10

Mod Version

1.2.1

Minecraft Version

1.18.2

Forge Version

actually it's fabric 1.18.2

Other Mods

rhino-fabric-1802.2.1-build.252
architectury-4.10.86
kubejs-fabric-1802.5.5-build.554
mcda-2.0.7
mcdw-5.0.4
cloth-config-6.2.57
bygonenether-1.18-1.2.2
fabric-api-0.67.0

Additional Context

No response

@Rad586 Rad586 added the bug Something isn't working label Mar 23, 2023
@github-actions github-actions bot added the 1.18.2 Issue happened in 1.18.2 label Mar 23, 2023
@izofar izofar added the fabric Fabric related label May 6, 2023
@izofar
Copy link
Owner

izofar commented Sep 12, 2023

This is a QOL suggestion, and unfortunately a not-so-simple fix because the recipes for gilded netherite are added via datapack. Can you kindly explain how smithing in the mod pack is "broken" rather than inconvenience?

@izofar izofar added suggestion New feature or request and removed bug Something isn't working labels Sep 12, 2023
@Rad586
Copy link
Contributor Author

Rad586 commented Sep 14, 2023

This is a QOL suggestion, and unfortunately a not-so-simple fix because the recipes for gilded netherite are added via datapack. Can you kindly explain how smithing in the mod pack is "broken" rather than inconvenience?

It also influence the entire shift placing behavior in smithing table. Now shift placement is only useable when player put the armor in the right place. It would be confusing if a modpack has a smithing recipe like iron axe+iron axe. But afterall, it's not that broken.

I noticed you mentioned the gilded netherite recipe. I used kubejs to disable all recipes added by this mod, but the problem still exists. Maybe the src/main/java/com/izofar/bygonenether/mixin/ModifyDamageInSmithingRecipes.java is causing it? I wa wondering if it's fine to use the vanilla method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.18.2 Issue happened in 1.18.2 fabric Fabric related suggestion New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants