Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate the importance of ratios #27

Open
j5v opened this issue Jun 18, 2023 · 0 comments
Open

Calculate the importance of ratios #27

j5v opened this issue Jun 18, 2023 · 0 comments
Labels
could-do enhancement New feature or request question Further information is requested

Comments

@j5v
Copy link
Owner

j5v commented Jun 18, 2023

The named ratios already have a .level property in ref.noteNamesHarmonic[], which indicates their importance in the UI (low values for .level imply important notes). More important ratios are displayed as heavier lines in the tuning row, and their shorthand labels display above the note button.

However, this applies only for ratios below integer limit 11.

Do we need to calculate the importance of other ratios, or ED generated notes that are near important ratios?

If yes, do we need to dynamically change the thresholds for visual effects? We currently have configurable thresholds for:

config: {
    ...
    noteShowSubtleLinesBelowLevel: 5,
    noteShowLabelsBelowLevel: 3,
    nearEnoughCents: 8, // for letter labels of notes
    ...
}
@j5v j5v added enhancement New feature or request question Further information is requested could-do labels Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could-do enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant