Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asset_host #9

Open
fbjork opened this issue Dec 2, 2010 · 3 comments
Open

asset_host #9

fbjork opened this issue Dec 2, 2010 · 3 comments

Comments

@fbjork
Copy link
Contributor

fbjork commented Dec 2, 2010

Hey,

just out of curiosity why is the asset_host being set in jammit-s3? Why not leave it to the environment specific config.action_controller.asset_host value?
@kmamykin
Copy link
Collaborator

IMHO having all settings in one place (assets.yml) simplify maintenance

@fbjork
Copy link
Contributor Author

fbjork commented Jan 25, 2011

When used with other gems like Carrerwave the asset_host manipulation done with jammit-s3 breaks functionality.

@kmamykin
Copy link
Collaborator

Jammit-s3 sets asset_host in before_configuration block when initializing. So if it conflicts with anything, override it in config/environments/production.rb as usual.
I saw your commit when you moved the setting from the gem but did not understand the reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fbjork @kmamykin