Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Javadoc for ContainerProvider #252

Closed
markt-asf opened this issue Apr 21, 2018 · 4 comments
Closed

Cleanup Javadoc for ContainerProvider #252

markt-asf opened this issue Apr 21, 2018 · 4 comments

Comments

@markt-asf
Copy link
Contributor

The line lengths are somewhat varied and the description for getCotnainer() doesn't look write. It doesn;t load the implementation, it creates an instance.

@joakime
Copy link
Contributor

joakime commented Apr 23, 2018

Do we want to provided advice in #getWebSocketContainer() about repeated use of that method - see #212

Even if #212 is fixed, the older code using the original behavior would still be at risk if using #getWebSocketContainer() without being aware of the repercussions.

@markt-asf
Copy link
Contributor Author

I don't agree with the premise of #212 and I have concerns regarding the proposed addition. I'm not against adding to the #getWebSocketContainer() Javadoc if necessary but I don't think there is consensus on what, if anything, should be added. My preference is to handle any Javadoc changes as a result of #212 as part of the fix for #212 and not try and consider them here.

@joakime
Copy link
Contributor

joakime commented Apr 23, 2018

Fair point.
I'll work up something for the mailing list about "Obtain a new instance of a WebSocketContainer." and how #212 and #230 overlap with this javadoc and the prior cache proposal.

@markt-asf
Copy link
Contributor Author

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants