Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waypoints/dataslide doesn't update correctly. #25

Open
joshlevinson opened this issue Jul 13, 2013 · 5 comments
Open

Waypoints/dataslide doesn't update correctly. #25

joshlevinson opened this issue Jul 13, 2013 · 5 comments

Comments

@joshlevinson
Copy link

The waypoints don't correctly update the navbar.

Logging the 'dataslide' variable in scripts.js shows that the waypoint doesn't update to the current slide until the viewport is past the padding.

This happens even on the sample site you've linked to.

@jereekespiritu
Copy link

This is the same problem I've been trying to fix but since I don't know much about jQuery, I can't. I do hope someone would help us about this.

@jalxob
Copy link
Owner

jalxob commented Jul 15, 2013

Hi guys! Sorry for being not available but I have been very busy. Why dont you try with this: #11 ?

@joshlevinson
Copy link
Author

@jalxob, unfortunately your example website still doesn't behave correctly. When I click "Demo", it scrolls to the demo section, but the nav updates to "What is it?"

@robinVR
Copy link

robinVR commented Sep 6, 2013

Perhaps try replacing waypoints.js with http://trevordavis.net/blog/jquery-one-page-navigation-plugin this does not have the same issues that waypoints is having.

@keroberts
Copy link

I have fixed the waypoint inaccuracy by using waypoints v2 and specifying two waypoints.

The slide needs to PASS the waypoint to trigger. And because of this a single offset waypoint would only ever get triggered in one direction.

So by using two waypoints you can cover both up and down.

I've also added script to dynamically get the .menu height, so the header can be responsive, and not have to rely on using padding on the slide to move the content from under the header.

See my post for all the code:

#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants