Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Hash Modification #29

Open
kbosu31 opened this issue Aug 14, 2013 · 4 comments
Open

URL Hash Modification #29

kbosu31 opened this issue Aug 14, 2013 · 4 comments

Comments

@kbosu31
Copy link

kbosu31 commented Aug 14, 2013

Does anyone have any modified code on this that would update the url hash on navigation click? I'm also looking for a way to link to a particular panel from an outside resource by passing a hash through the url? Surely someone has integrated this framework with that feature.

@JacobBennett
Copy link

Hey there @kbosu31.

I just forked the repo and submitted a pull request to do what you are asking about here.

You can find it in the meantime at

https://github.com/JacobBennett/cool-kitten/tree/patch-1

The only thing modified is the script.js file by the way.

This essentially allows you to use the data-slide attribute on the nav li elements to link directly to id's on slides and updates the URL hash when arriving at those locations.

Example

<li data-slide='about'>About Section</li>

<div class="slide" id="about">Hey there this is my about section</div>

Very briefly described, the framework would smooth scroll to the div that has a matching ID and update the URL hash once it arrived at that location. Hope this helps!

@JacobBennett
Copy link

@kbosu31 did you end up using this?

@kbosu31
Copy link
Author

kbosu31 commented Aug 15, 2013

Yes. Your solution worked great!

Sent from my iPhone

On Aug 15, 2013, at 4:08 PM, Jacob Bennett [email protected] wrote:

@kbosu31 https://github.com/kbosu31 did you end up using this?


Reply to this email directly or view it on
GitHubhttps://github.com//issues/29#issuecomment-22730342
.

@JacobBennett
Copy link

@kbosu31 Great! Glad it helped. Hopefully we can get @jalxob to pull it into his repo. I think it adds a lot of value semantically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants