Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram and Compilation error #5

Open
AnalogThinker opened this issue Dec 31, 2020 · 3 comments
Open

Diagram and Compilation error #5

AnalogThinker opened this issue Dec 31, 2020 · 3 comments

Comments

@AnalogThinker
Copy link

Diagram (first half) shows:
A4 --- RAM A5 (Should show A4 --- RAM A4)
A6 --- RAM A7 (Should show A6 --- RAM A6)

Upload fails on MEGA if 3 exclamation marks are sent.
Change "Serial.println("FAIL!!!");" to be "Serial.println("FAIL!");"

@jamarju
Copy link
Owner

jamarju commented Jan 1, 2021

You are right. Thank you for pointing it out!

Do you think you can send me a pull request with the fix so that I can merge it right in?

@AnalogThinker
Copy link
Author

Apologies I'm not sure how to do this, not quite familiar with GitHub, would you mind guiding me?

@jamarju
Copy link
Owner

jamarju commented Feb 1, 2021

You should first fork my repo, then clone your own fork (http://github.com/AnalogThinker/c64_test_tools). Fix the problem there, do a git commit and a git push to commit it to your repo. Then, follow this:

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants