Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compatibility #65

Closed
nstCactus opened this issue Aug 5, 2021 · 3 comments
Closed

PHP 8 compatibility #65

nstCactus opened this issue Aug 5, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@nstCactus
Copy link
Contributor

Currently the plugin is not compatible with PHP 8 due to a dependency to abraham/twitteroauth:^1.0.

The latest version of abraham/twitteroauth seems compatible with PHP 8.0. I have no idea of the amount of work required to make the plugin compatible with the latest version, but it would help in PHP 8 compatibility.

Composer returns the following error when trying to install on PHP 8:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - jamesedmonston/graphql-authentication[1.10.0, ..., 1.10.3] require abraham/twitteroauth ^1.0 -> satisfiable by abraham/twitteroauth[1.0.0, 1.0.1, 1.1.0, 1.2.0].
    - abraham/twitteroauth[1.0.0, ..., 1.0.1] require php ^5.6 || ^7.0 || ^7.1 || ^7.2 -> your php version (8.0.7) does not satisfy that requirement.
    - abraham/twitteroauth 1.1.0 requires php ^7.2 || ^7.3 -> your php version (8.0.7) does not satisfy that requirement.
    - abraham/twitteroauth 1.2.0 requires php ^7.2 || ^7.3 || ^7.4 -> your php version (8.0.7) does not satisfy that requirement.
    - Root composer.json requires jamesedmonston/graphql-authentication ^1.10 -> satisfiable by jamesedmonston/graphql-authentication[1.10.0, 1.10.1, 1.10.2, 1.10.3].
@jamesedmonston jamesedmonston self-assigned this Aug 5, 2021
@jamesedmonston jamesedmonston added the bug Something isn't working label Aug 5, 2021
@jamesedmonston
Copy link
Owner

@nstCactus thanks for the heads up! I'll get an env set up locally and check it out.

@holmey
Copy link

holmey commented Aug 5, 2021

PHP 8 support would be great. I configured an alias for abraham/twitteroauth so this plugin is used in the latest version.
But when this issues was resolved i figured out that also facebook/graph-sdk does not have support for PHP 8 and it does not get support anytime soon because it seems to be archived .

@jamesedmonston
Copy link
Owner

jamesedmonston commented Aug 14, 2021

I've just released 1.11.0 which includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants