Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Time datatype #523

Open
calum-maclean-ul opened this issue Jan 4, 2024 · 3 comments
Open

Add support for Time datatype #523

calum-maclean-ul opened this issue Jan 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@calum-maclean-ul
Copy link

In DataType.readDataType(), for case 2 (Time), UnsupportedHdfException is currently thrown.

It would be useful if support could be added for Time, so that files which contain them can be loaded.

@jamesmudd
Copy link
Owner

Thanks for looking at jHDF and finding this issue. Your right that Time is currently not supported. I would be happy to look at how difficult this would be.

Do you have a sample file you would like to be able to read that I can test with?

@calum-maclean-ul
Copy link
Author

Sample.zip

Thanks for the quick response. jhdf is working great for me, apart from these issues with my file content.

Note that the sample file contains both the Time datatype and the version = 0 issue. I've added temporary workarounds to my local copy of the repo: to use OpaqueDataType for Time; and to comment out the version check.

@ZhaoMJ
Copy link

ZhaoMJ commented Jan 15, 2024

I've faced the same issue, both with the Time datatype and DataType.version = 0.

@jamesmudd jamesmudd added the enhancement New feature or request label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants