Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postcard_rpc::host_client::IoClosed should implement core::error::Error #79

Open
zeenix opened this issue Jan 16, 2025 · 2 comments
Open
Labels
good first issue Good for newcomers

Comments

@zeenix
Copy link
Contributor

zeenix commented Jan 16, 2025

It should be trivial. The only issue is that Error trait was added to core in 1.81. If that's too new of a Rust release to require, then you want to implement std::error::Error when use-std is enabled.

@jamesmunns
Copy link
Owner

Happy to take a PR for this. We don't have any specific MSRV guarantees, so if it works on current stable I am likely to be fine with that.

@jamesmunns jamesmunns added the good first issue Good for newcomers label Jan 29, 2025
@jamesmunns
Copy link
Owner

Oh, also, fwiw, the host_client parts are currently only intended for std, so implementing either core::error::Error or just std::error::Error should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants