Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install fails to build on Python 3.13 #217

Closed
Arcturuss opened this issue Oct 14, 2024 · 12 comments · Fixed by #218
Closed

Install fails to build on Python 3.13 #217

Arcturuss opened this issue Oct 14, 2024 · 12 comments · Fixed by #218

Comments

@Arcturuss
Copy link

Basically same as #199

Python 3.13.0 just released, and there is no prebuilt packages for it, I guess.

@jamesturk
Copy link
Owner

I haven't had the chance to figure out why the build is failing on Windows yet, which is holding up the release.

@jamesturk jamesturk reopened this Oct 25, 2024
@energynumbers
Copy link
Contributor

Any progress on this? Is there a way to build for windows yet, for python 3.13?

@jamesturk
Copy link
Owner

jamesturk commented Dec 2, 2024

No, I don't have access to a Windows system to test so sort of at the whim of GitHub Actions, if someone wants to work on this it'd be welcome!

@energynumbers
Copy link
Contributor

ok, I've never used rust or maturin before, but I'll give it a go

@energynumbers
Copy link
Contributor

ok, it said:
Finished dev profile [unoptimized + debuginfo] target(s) in 1m 03s
📦 Built wheel for CPython 3.13 to D:\zaps\jellyfish\target\wheels\jellyfish-1.1.0-cp313-cp313-win_amd64.whl

Wheel then installs ok on python 3.13

First time success. Built on windows 10, python 3.13.

That's good, right? Should I be trying some profile other than dev?

@energynumbers
Copy link
Contributor

energynumbers commented Dec 2, 2024

dropbox link to compiled wheels:

@energynumbers
Copy link
Contributor

energynumbers commented Dec 2, 2024

So, the release profile built ok too, once I realised I just needed to run maturin build -r

Maybe it was because I was compiling using python 3.13, maybe because it was a very clean new install of both rust and maturin, but there were no warnings or hiccups.

@energynumbers
Copy link
Contributor

Ah, I think this is the underlying problem: PyO3/maturin-action#292 (comment)

Python 3.13 isn't installed by default in Actions runner yet: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#python
You can install it before building using setup-python action manually for the moment.

energynumbers added a commit to energynumbers/jellyfish that referenced this issue Dec 2, 2024
jamesturk pushed a commit that referenced this issue Dec 3, 2024
* Update CI.yml

fix for #217

* try fix for the windows matrix
@jamesturk
Copy link
Owner

thanks for this, release was pushed!

@tswast
Copy link

tswast commented Dec 9, 2024

I'm only seeing Windows 3.9 support for the compiled builds on the files for 1.1.2, which is the most recent release.

@energynumbers
Copy link
Contributor

@jamesturk that is odd - I'm seeing the same as tswast - the windows py-3.13 build goes fine, but it doesn't get uploaded to pypi.org upon release. I've never uploaded to pypi, so I don't know what's going on here, but it seems a strange thing, and it means that lots of users still won't be able to use jellyfish on python 3.13 on windows.

@energynumbers
Copy link
Contributor

ok, I think this should fix it #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants