Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to change code in match_idf_surfaces function #192

Open
katsuya0719 opened this issue Jul 7, 2020 · 3 comments
Open

Suggestion to change code in match_idf_surfaces function #192

katsuya0719 opened this issue Jul 7, 2020 · 3 comments
Labels

Comments

@katsuya0719
Copy link

I was testing intersect_match function using simple 2 boxes stacking vertically which has adjscency between roof and floor. However, all the outside boundary condition set to outside which implies this API is not working properly. After investigation, I found that if I change following code to suggestion code in match_idf_surfaces, the problem is fixed.
I understand intension in original code but suggestion code could widen the case which caught by this if sentence.
What do you think about this revision and if you have some intension to keep original code, I would like to know.
Original code.
if almostequal(s.coords, reversed(m.coords)):.

Suggestion code.
if almostequal(sorted(s.coords),sorted(m.coords)):

@jamiebull1
Copy link
Owner

Happy to take a PR with a test case. Thanks for the suggestion.

@Lantonshen
Copy link

This new update is available on which version of geomeppy? My version is 0.11.8. The problem is still there.

@JoLo90
Copy link
Contributor

JoLo90 commented Apr 23, 2021

Great fix @katsuya0719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants