Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty boundary polygon #87

Open
jannikmi opened this issue Apr 18, 2024 · 6 comments
Open

Allow empty boundary polygon #87

jannikmi opened this issue Apr 18, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jannikmi
Copy link
Owner

In some scenarios there might not be explicit boundaries. Allow the boundary polygon parameter to be None.

Note: If the boundary polygon is None, there must be holes given

Quick workaround: take a simple recangle containing all given holes.

@jannikmi jannikmi added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 18, 2024
@Sherwin-14
Copy link

Hey do you have some specific opinions regarding this?

@jannikmi
Copy link
Owner Author

Not really. You are welcome to contribute!

@Sherwin-14
Copy link

I'll start working on this.;).

@jannikmi
Copy link
Owner Author

Great! You can open a (draft) pull request to keep track of the progress. I will support with code review and guidance.

@Sherwin-14
Copy link

@jannikmi, Hey I had been working on this and I have been trying to solve this issue using the following process:

  1. We check if the boundary coordinates are None for a particular case, if they are None then we populate the boundary coordinates array with values present in list_of_holes.

  2. Once we do the above, we then send all of this information to the plotting function which takes care of plotting the rectangle that would be made using these boundary coordinates.

Is this approach feasible to you? I am asking this since I have been running into some errors and I think it maybe down to the approach that I am using? Would appreciate your take on this .

@jannikmi
Copy link
Owner Author

Could you please open a PR with you changes. Then I can advise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants