diff --git a/.changeset/unlucky-jars-protect.md b/.changeset/unlucky-jars-protect.md
new file mode 100644
index 0000000000..a845151cc8
--- /dev/null
+++ b/.changeset/unlucky-jars-protect.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/plugins/orchestrator/src/components/WorkflowInstancePageContent.tsx b/plugins/orchestrator/src/components/WorkflowInstancePageContent.tsx
index b13113b8bf..830710d83d 100644
--- a/plugins/orchestrator/src/components/WorkflowInstancePageContent.tsx
+++ b/plugins/orchestrator/src/components/WorkflowInstancePageContent.tsx
@@ -100,7 +100,6 @@ export const WorkflowInstancePageContent: React.FC<{
diff --git a/plugins/orchestrator/src/components/WorkflowInstanceStatusIndicator.tsx b/plugins/orchestrator/src/components/WorkflowInstanceStatusIndicator.tsx
index 0bde12c694..5cfa31cdc6 100644
--- a/plugins/orchestrator/src/components/WorkflowInstanceStatusIndicator.tsx
+++ b/plugins/orchestrator/src/components/WorkflowInstanceStatusIndicator.tsx
@@ -8,7 +8,6 @@ import DotIcon from '@material-ui/icons/FiberManualRecord';
import {
capitalize,
ProcessInstanceStatusDTO,
- WorkflowResultDTOCompletedWithEnum,
} from '@janus-idp/backstage-plugin-orchestrator-common';
import { VALUE_UNAVAILABLE } from '../constants';
@@ -18,40 +17,26 @@ import { workflowInstanceRouteRef } from '../routes';
export const WorkflowInstanceStatusIndicator = ({
status,
lastRunId,
- completedWith,
}: {
status?: ProcessInstanceStatusDTO;
lastRunId?: string;
- completedWith?: WorkflowResultDTOCompletedWithEnum;
}) => {
- const iconColor = useWorkflowInstanceStateColors(
- status === ProcessInstanceStatusDTO.Completed && completedWith === 'error'
- ? ProcessInstanceStatusDTO.Error
- : status,
- );
+ const iconColor = useWorkflowInstanceStateColors(status);
const workflowInstanceLink = useRouteRef(workflowInstanceRouteRef);
if (!status) {
return VALUE_UNAVAILABLE;
}
- let statusText: string = status;
- if (
- status === ProcessInstanceStatusDTO.Completed &&
- completedWith === 'error'
- ) {
- statusText = 'Completed with error';
- }
-
return (
<>
{' '}
{lastRunId ? (
- {capitalize(statusText)}
+ {capitalize(status)}
) : (
- <>{capitalize(statusText)}>
+ <>{capitalize(status)}>
)}
>
);
diff --git a/plugins/orchestrator/src/components/WorkflowRunDetails.tsx b/plugins/orchestrator/src/components/WorkflowRunDetails.tsx
index 34d3a5982e..e02328149d 100644
--- a/plugins/orchestrator/src/components/WorkflowRunDetails.tsx
+++ b/plugins/orchestrator/src/components/WorkflowRunDetails.tsx
@@ -10,7 +10,6 @@ import {
capitalize,
ProcessInstanceDTO,
ProcessInstanceStatusDTO,
- WorkflowResultDTOCompletedWithEnum,
} from '@janus-idp/backstage-plugin-orchestrator-common';
import { VALUE_UNAVAILABLE } from '../constants';
@@ -21,7 +20,6 @@ import { WorkflowRunDetail } from './WorkflowRunDetail';
type WorkflowDetailsCardProps = {
assessedBy?: ProcessInstanceDTO;
details: WorkflowRunDetail;
- completedWith?: WorkflowResultDTOCompletedWithEnum;
};
const useStyles = makeStyles({
@@ -34,7 +32,6 @@ const useStyles = makeStyles({
export const WorkflowRunDetails: React.FC = ({
assessedBy,
details,
- completedWith,
}) => {
const styles = useStyles();
const workflowInstanceLink = useRouteRef(workflowInstanceRouteRef);
@@ -54,7 +51,6 @@ export const WorkflowRunDetails: React.FC = ({