Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance janus-idp/cli "new" command to include a working turbo.json and tsconfig.json #1105

Closed
gashcrumb opened this issue Jan 23, 2024 · 3 comments · Fixed by #782
Closed
Assignees
Labels
jira kind/enhancement New feature or request

Comments

@gashcrumb
Copy link
Member

What do you want to improve?

It'd be helpful if the janus-idp/cli new command also inlcuded working turbo.json and tsconfig.json files, as well as maybe include a tsc command and adds dynamic plugin support out of the box. Maybe the latter two can be extra credit :-)

What is the current behavior?

  1. Run ./packages/cli/bin/janus-cli new to create a new plugin in backstage-plugins
  2. Add "tsc": "tsc" to the plugin's package.json's scripts section
  3. Run yarn tsc and observe errors.
  4. Copy turbo.json and tsconfig.json from someone else's plugin and adapt.

What will the new behavior be?

After running the new command the aforementioned files should be present and set up appropriately so that after creating a new plugin, yarn tsc and yarn build at the root should work and include the newly created plugin.

@davidfestal
Copy link
Member

Maybe what you're looking for is already included into PR #782 ?

@tumido
Copy link
Member

tumido commented Jan 24, 2024

All of this is already part of #782 🙂

@gashcrumb
Copy link
Member Author

That's excellent, thanks! Will have a 👀

@gashcrumb gashcrumb changed the title Enhance @janus-idp/cli "new" command to include a working turbo.json and tsconfig.json Enhance janus-idp/cli "new" command to include a working turbo.json and tsconfig.json Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira kind/enhancement New feature or request
Projects
None yet
3 participants