Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn tsc failing on orchestrator-backend on the main branch #1848

Closed
rm3l opened this issue Jun 27, 2024 · 2 comments
Closed

yarn tsc failing on orchestrator-backend on the main branch #1848

rm3l opened this issue Jun 27, 2024 · 2 comments
Labels
jira kind/bug Something isn't working status/triage

Comments

@rm3l
Copy link
Member

rm3l commented Jun 27, 2024

Describe the bug

I rebased my PR (#1471) onto main, and noticed some failures due to recent changes in the orchestrator-backend.

I checked main and noticed that yarn tsc also errors out.

https://github.com/janus-idp/backstage-plugins/actions/runs/9698241417/job/26765971595

Expected Behavior

yarn tsc should pass with no error.

What are the steps to reproduce this bug?

$ yarn workspace @janus-idp/backstage-plugin-orchestrator-backend tsc

yarn workspace v1.22.20
yarn run v1.22.20
$ tsc
src/service/router.ts:1178:31 - error TS2304: Cannot find name 'JiraEvent'.

1178     const event = req.body as JiraEvent;
                                   ~~~~~~~~~

src/service/router.ts:1179:20 - error TS2339: Property 'jiraService' does not exist on type 'PublicServices'.

1179     await services.jiraService.handleEvent(event);
                        ~~~~~~~~~~~

Found 2 errors in the same file, starting at: src/service/router.ts:1178

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 2
Command: /home/asoro/.nvm/versions/node/v20.12.2/bin/node
Arguments: /home/asoro/.nvm/versions/node/v20.12.2/lib/node_modules/yarn/lib/cli.js tsc
Directory: /home/asoro/work/projects/backstage/janus-idp/backstage-plugins/plugins/orchestrator-backend
Output:

info Visit https://yarnpkg.com/en/docs/cli/workspace for documentation about this command.

Versions of software used and environment

$ node --version                                                
v20.12.2

$ yarn --version                                                     
1.22.20
@rm3l rm3l added kind/bug Something isn't working status/triage labels Jun 27, 2024
@rm3l rm3l changed the title yarn tsc failing orchestrator-backend on the main branch yarn tsc failing on orchestrator-backend on the main branch Jun 27, 2024
@github-actions github-actions bot added the jira label Jun 27, 2024
@rm3l
Copy link
Member Author

rm3l commented Jun 27, 2024

/cc @anludke
/cc @gciavarrini

Seems to be related to #1833 which was merged recently.

@gciavarrini
Copy link
Contributor

@rm3l Thanks for opening this issue.
Fixed by #1850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira kind/bug Something isn't working status/triage
Projects
None yet
Development

No branches or pull requests

2 participants