From 2eaa82ca776a6de378db055192ff95a8c76ee970 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jarda=20Kot=C4=9B=C5=A1ovec?= <jarda.kotesovec@gmail.com>
Date: Thu, 26 Sep 2024 11:32:14 +0200
Subject: [PATCH] Add message that deciding editors needs to be assigned before
 making decision

---
 .../WorkflowRecommendOnlyControls.vue         | 24 +++++++++++++++---
 .../composables/useWorkflowEditorialConfig.js | 25 +++++++++++--------
 2 files changed, 34 insertions(+), 15 deletions(-)

diff --git a/src/pages/dashboard/SubmissionSummaryModal/actionItems/WorkflowRecommendOnlyControls.vue b/src/pages/dashboard/SubmissionSummaryModal/actionItems/WorkflowRecommendOnlyControls.vue
index 07fdec40f..4c0dbf54c 100644
--- a/src/pages/dashboard/SubmissionSummaryModal/actionItems/WorkflowRecommendOnlyControls.vue
+++ b/src/pages/dashboard/SubmissionSummaryModal/actionItems/WorkflowRecommendOnlyControls.vue
@@ -1,6 +1,6 @@
 <template>
 	<div
-		v-if="!isLoading && currentRecommendation"
+		v-if="!isDecidingEditorAssigned || (!isLoading && currentRecommendation)"
 		class="w-full border border-light"
 	>
 		<div class="p-4">
@@ -8,7 +8,10 @@
 				{{ t('editor.submission.recommendation') }}
 			</h2>
 		</div>
-		<div class="flex flex-col border-t border-light p-4">
+		<div
+			v-if="isDecidingEditorAssigned"
+			class="flex flex-col border-t border-light p-4"
+		>
 			<p class="text-lg-normal text-default">
 				{{ currentRecommendation.label }}
 			</p>
@@ -18,6 +21,11 @@
 				</PkpButton>
 			</span>
 		</div>
+		<div v-else class="p-4">
+			<p class="text-lg-normal text-default">
+				{{ t('editor.submission.recommendation.noDecidingEditors') }}
+			</p>
+		</div>
 	</div>
 	<div v-if="showRecommendationActions" class="flex flex-col gap-y-2">
 		<PkpButton
@@ -44,7 +52,7 @@ import {Actions as WorkflowActions} from '../../composables/useWorkflowActions';
 const {t} = useLocalize();
 
 const props = defineProps({
-	submissionId: {type: Number, required: true},
+	submission: {type: Object, required: true},
 	reviewRoundId: {type: Number, required: true},
 	stageId: {type: Number, required: true},
 	userId: {type: Number, required: true},
@@ -59,7 +67,15 @@ const RecommendOnlyDecisions = [
 
 const explicitelyShowRecommendationActions = ref(false);
 
+const isDecidingEditorAssigned = computed(() => {
+	return props.submission?.editorAssigned;
+});
+
 const showRecommendationActions = computed(() => {
+	if (!isDecidingEditorAssigned.value) {
+		return false;
+	}
+
 	if (explicitelyShowRecommendationActions.value) {
 		return true;
 	}
@@ -101,7 +117,7 @@ const actionItems = computed(() => {
 
 const {apiUrl: recommendationApiUrl} = useUrl(
 	// TODO improve url when the query params are available
-	`submissions/${props.submissionId}/decisions`,
+	`submissions/${props.submission?.id}/decisions`,
 );
 
 const {
diff --git a/src/pages/dashboard/SubmissionSummaryModal/composables/useWorkflowEditorialConfig.js b/src/pages/dashboard/SubmissionSummaryModal/composables/useWorkflowEditorialConfig.js
index b5555a59f..c360e0806 100644
--- a/src/pages/dashboard/SubmissionSummaryModal/composables/useWorkflowEditorialConfig.js
+++ b/src/pages/dashboard/SubmissionSummaryModal/composables/useWorkflowEditorialConfig.js
@@ -203,17 +203,21 @@ export const WorkflowConfig = {
 			return items;
 		},
 		getSecondaryItems: ({submission, selectedReviewRound, selectedStageId}) => {
-			// TODO add isDecidingEditor boolean to api
 			const items = [];
-			items.push({
-				component: 'WorkflowRecommendOnlyListingRecommendations',
-				props: {
-					submission: submission,
-					stageId: pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW,
-					reviewRoundId: selectedReviewRound.id,
-				},
-			});
 
+			// TODO add isDecidingEditor boolean to api to make it more accurate
+			const selectedStage = getStageById(submission, selectedStageId);
+			const isRecommendOnlyEditor = selectedStage.currentUserCanRecommendOnly;
+			if (!isRecommendOnlyEditor) {
+				items.push({
+					component: 'WorkflowRecommendOnlyListingRecommendations',
+					props: {
+						submission: submission,
+						stageId: pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW,
+						reviewRoundId: selectedReviewRound.id,
+					},
+				});
+			}
 			items.push({
 				component: 'ParticipantManager',
 				props: {
@@ -255,7 +259,7 @@ export const WorkflowConfig = {
 				items.push({
 					component: 'WorkflowRecommendOnlyControls',
 					props: {
-						submissionId: submission.id,
+						submission: submission,
 						userId: pkp.currentUser.id,
 						stageId: pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW,
 						reviewRoundId: selectedReviewRound.id,
@@ -756,7 +760,6 @@ export function useWorkflowEditorialConfig() {
 				selectedStageId: selectedMenuState.stageId,
 				selectedReviewRound,
 			};
-			console.log('itemsArgs:', itemsArgs);
 			if (!submission) {
 				return [];
 			}