Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response_type hard coded #68

Open
mattdot opened this issue Oct 28, 2016 · 6 comments
Open

response_type hard coded #68

mattdot opened this issue Oct 28, 2016 · 6 comments

Comments

@mattdot
Copy link

mattdot commented Oct 28, 2016

I'm implementing a passport provider for visual studio online and they use response_type=Assertion (docs @ https://www.visualstudio.com/en-us/docs/integrate/get-started/auth/oauth ). Unfortunately passport-oauth2 hardcodes response_type=code. Would you be open to a pull request that allows derived strategies to override the response_type? I got my passport provider working by just copying the entire authorize implementation, but it seems like I shouldn't have had to do that.

https://github.com/mattdot/passport-visualstudio/blob/master/lib/strategy.js

@josefwijaya
Copy link

+1

3 similar comments
@ceceliastory
Copy link

+1

@jeremy-ww
Copy link

+1

@brunosantanarj
Copy link

+1

@shushu304
Copy link

shushu304 commented Mar 17, 2019

+1
if you can update the strategy.js line 217 to :
params.response_type = params.response_type || 'code';
it will be great.

@robballou
Copy link

robballou commented Aug 23, 2019

Related PR #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants