Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields: Code Cleanup: move non-field functionality to other file #220

Open
henrygab opened this issue Nov 28, 2021 · 0 comments
Open

Fields: Code Cleanup: move non-field functionality to other file #220

henrygab opened this issue Nov 28, 2021 · 0 comments

Comments

@henrygab
Copy link
Collaborator

Originally posted by @tobi01001 in #216 (comment)

In particular, the following should be moved elsewhere:

  • [] power variable
  • [] brightness variable
  • [] setShowClock() function
  • [] setClockBackgroundFade() function
  • [] setUtcOffsetIndex() function

Consider also making some function templates to further consolidate the functions for get/set of the variables. This should reduce bugs when needing to add new functionality (such as websocket transmissions on value changes), for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant