Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README is wrong #16

Open
Sophrinix opened this issue Nov 17, 2016 · 3 comments
Open

README is wrong #16

Sophrinix opened this issue Nov 17, 2016 · 3 comments

Comments

@Sophrinix
Copy link

You can have different styles (TSS), views (XML), app icons, splash screens and assets per theme

While it is possible to have a commonJS module or even a processed controller ( which would be pointless) in a theme, it is not possible to have views in a theme. I am considering my option with regard to making this possible.

Would a PR to this project be a suitable place to make such a code change?
It would introduce Alloy as a dependency to this project.

@jasonkneen
Copy link
Owner

Sounds interesting. So an XML view in a theme folder?

@Sophrinix
Copy link
Author

Sophrinix commented Nov 17, 2016

Correct.
I've observed a few behaviors:
First, the alloy compile --config ... file= command only works for controllers that are inside the /app directory.
Second, in a theme folder if you have lib/alloy/{views, controllers,styles}, they copy over into Resources/{iphone,android}/alloy/ -- but does not process them -- before "MVC generation" starts, aka alloy processes the views into the controllers and places them in that aforementioned path.

This feels like incomplete functionality. In fact, Appcelerator made a ticket to make this a thing a while ago: https://jira.appcelerator.org/browse/ALOY-1307 but never got around to it.

I'm thinking this improvement could go in either this project or TiTh

@jasonkneen
Copy link
Owner

PR would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants