CPU Restriction is unstable

[Frontrider]

as I noted in #52 the CPU control method sometimes throws a RuntineException instead of the expected ScriptCPUAbuseException.

It's a rare occasion (The unit tests sometimes fail for no reason), but I can confirm that it can happen, and should be handled.

[mxro]

Thank you for reporting this as well. So would you say the fix is to change the unit tests or to try to force throwing a ScriptCPUAbuse exception always? What kind of RuntimeException is triggered? Thank you!

[Frontrider]

Simply a runtime exception. No other thing is known.

It's extremely rare, only happened once, but it should still be noted, that it has a very slight chance to do that. Might have been something thread related. Like it crashed while it was trying to shut it down.

From what I see, that method should not throw anything else, under normal circumstances. That is what we expect, that is what we test for.

[mxro]

Given that this appears only very rarely, I don't think there is anything we can do about it at the moment since we won't be able to pinpoint where the RuntimeException originates from.

In any case, will leave this issue open in case that exception comes up again. Then we could add the stack trace for the RuntimeException and that will maybe help debug it!