Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiCommand(or upstream) needs to fail in case of failed invocation with proper info #35

Open
baranowb opened this issue Feb 4, 2025 · 2 comments

Comments

@baranowb
Copy link
Contributor

baranowb commented Feb 4, 2025

There is no sanity check here, this can lead to malformed outcome:

"
$ pr-merge upstream 4785
The hub commandline tool is not installed. Using curl.
Merging 4785 from upstream onto 7.4.x-proposed
The hub commandline tool is not installed. Using curl.

Retrieving PR information from https://api.github.com/repos/jbossas/jboss-eap7/pulls/4785... Done.
Git commit message will be: Merge pull request #4785 from
Continue...^C
"

With success:
"
$ pr-merge upstream 4785
The hub commandline tool is not installed. Using curl.
Merging 4785 from upstream onto 7.4.x-proposed
The hub commandline tool is not installed. Using curl.

Retrieving PR information from https://api.github.com/repos/jbossas/jboss-eap7/pulls/4785... Done.
Git commit message will be: Merge pull request #4785 from istudens:JBEAP-28731 [WFLY-20102] only encode and log route for first getRoute call
Continue...

"

@baranowb
Copy link
Contributor Author

baranowb commented Feb 4, 2025

This is somewhat doubling #34

@baranowb
Copy link
Contributor Author

baranowb commented Feb 4, 2025

curl:
-S, --show-error Show error even when -s is used
-s, --silent Silent mode

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant