Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add C++11 standard requirement #29

Open
barracuda156 opened this issue Oct 19, 2023 · 3 comments
Open

Please add C++11 standard requirement #29

barracuda156 opened this issue Oct 19, 2023 · 3 comments

Comments

@barracuda156
Copy link

The build fails spectacularly with an older compiler which does not support C++11. CMake should require the standard.

@jbreams
Copy link
Owner

jbreams commented Oct 19, 2023

The C++ standard is set here

set (CMAKE_CXX_STANDARD 11)
, what else needs to be done here?

@barracuda156
Copy link
Author

@jbreams Thank you for responding!

I think it will be better to have it required: https://cmake.org/cmake/help/latest/prop_tgt/CXX_STANDARD_REQUIRED.html
Otherwise somebody gets a failure and won’t immediately know why.

@barracuda156
Copy link
Author

@jbreams FYI, I have added it to Macports: https://ports.macports.org/port/gonepass/details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants