Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular dependency between jcabi-log and jcabi-aspects #7

Open
reegnz opened this issue Dec 22, 2013 · 7 comments
Open

circular dependency between jcabi-log and jcabi-aspects #7

reegnz opened this issue Dec 22, 2013 · 7 comments

Comments

@reegnz
Copy link

reegnz commented Dec 22, 2013

jcabi-log depends on jcabi-aspects and vice-versa.

This circular dependency can be resolved by splitting jcabi-log into jcabi-log-api and jcabi-log-impl. The dependency to jcabi-aspects is only required bz jcabi-log-impl, and jcabi-aspects can only depend on jcabi-log-api.

@yegor256
Copy link
Member

@reegnz Yes, they depend on each other, but in fixed versions. How does it affect you? What problem do you experience? Can you post your pom.xml?

@reegnz
Copy link
Author

reegnz commented Dec 23, 2013

It doesn't affect anyone probably, since it is a project-architectural issue, not a bug.
Just trying to make constructive criticism of this promising little project. 👍

Anyways it still feels weird to see this. If it depends on a fixed version, how come it is not the latest version?

@yegor256
Copy link
Member

That's a valid question. The thing is that jcabi-aspects needs just basic functionality from jcabi-log, which existed since version 0.7 (or even earlier). That's why it's enough for jcabi-aspects to be dependent on jcab-log:0.7.

@yegor256
Copy link
Member

see jcabi/jcabi-aspects@58d2c80

@yegor256
Copy link
Member

@reegnz is it still an open bug? please close the issue if the problem is solved. thanks

@ittaiz
Copy link

ittaiz commented Dec 11, 2017

We hit this issue when trying to migrate a project from maven to bazel.
Bazel doesn't have version resolution mechanisms like maven and so we aligned on one version and got cyclic problems.
These can be worked around via depending on the "old" jcabi-log under a different name but it's brittle so we just stopped depending on jcabi all together.
Just another data point.

@flowgrad
Copy link

Got this when trying to use it in OSGi environment. Dropped this project faster then anything. Circular dependecies are a hint on low quality and lack of vision. Fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants