-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circular dependency between jcabi-log and jcabi-aspects #7
Comments
@reegnz Yes, they depend on each other, but in fixed versions. How does it affect you? What problem do you experience? Can you post your |
It doesn't affect anyone probably, since it is a project-architectural issue, not a bug. Anyways it still feels weird to see this. If it depends on a fixed version, how come it is not the latest version? |
That's a valid question. The thing is that jcabi-aspects needs just basic functionality from jcabi-log, which existed since version 0.7 (or even earlier). That's why it's enough for jcabi-aspects to be dependent on jcab-log:0.7. |
@reegnz is it still an open bug? please close the issue if the problem is solved. thanks |
We hit this issue when trying to migrate a project from maven to bazel. |
Got this when trying to use it in OSGi environment. Dropped this project faster then anything. Circular dependecies are a hint on low quality and lack of vision. Fix it. |
jcabi-log depends on jcabi-aspects and vice-versa.
This circular dependency can be resolved by splitting jcabi-log into jcabi-log-api and jcabi-log-impl. The dependency to jcabi-aspects is only required bz jcabi-log-impl, and jcabi-aspects can only depend on jcabi-log-api.
The text was updated successfully, but these errors were encountered: