Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using CGO_ENABLED=1 causes GetAvailableCoreWebView2BrowserVersionString to crash #49

Open
leaanthony opened this issue Jul 18, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@leaanthony
Copy link
Contributor

I'm looking to make a small, reproducible example but am opening this issue preemptively as there's a lot of detail on the linked issue:
wailsapp/wails#1569

Crux of the issue is it seems CGO interferes with the way go-winloader works. I'll update as I get more details. Cheers!

@jchv
Copy link
Owner

jchv commented Jul 18, 2022

I hope we can fix this, but I did always dislike the complexity of having to ship go-winloader like this. I should probably attempt to port OpenWebView2Loader to Go at some point; it would still involve some unsafety, but only as much as we ordinarily need for messing with COM, rather than the violently unsafe stuff that go-winloader does.

@stffabi
Copy link
Contributor

stffabi commented Aug 25, 2022

Initial work has been started in the Wails repo to port OpenWebView2Loader to Go. As a first step it's only used for GetAvailableCoreWebView2BrowserVersionString with a fixed runtime path, since that's the current issue for Wails.

More work is going on to fully port it to Go in the future. Just wanted to bring this up here, so we won't end up in doing the same work multiple times.

@jchv jchv added the bug Something isn't working label Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants