Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tokio::fs::File #8

Open
jdockerty opened this issue Mar 28, 2024 · 0 comments
Open

Use tokio::fs::File #8

jdockerty opened this issue Mar 28, 2024 · 0 comments

Comments

@jdockerty
Copy link
Owner

jdockerty commented Mar 28, 2024

After the introduction of tokio as a runtime (#7), there are still a few extra items which would be useful to get through.

Converting from the std::fs::File usage into tokio::fs::File would be useful for the many file I/O operations that are taken in the store. Most notably, I believe this would be largely beneficial for the set operation, as concurrent writes can .await insertion to the file.

This will require a change to the BufReaderWithPos too. It will need to implement AsyncRead, instead of its current Read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant