Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows with custom named seasons do not show their custom names, nor do they show season artwork #433

Open
TheFeshy opened this issue Nov 27, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@TheFeshy
Copy link

Describe the bug
I have a meta-show I have created, called "fitness." In it are "seasons" with each season representing one fitness show (e.g. P90X, P90X2, etc.) There is an info file with namedseason entries for each season, giving them a name. There are also seasonXX-fanart and seasonXX-poster files for these seasons.

Within the Jellyfin interface, this works as expected - navigating to the "Fitness" show I am presented a list of seasons with the appropriate names (e.g. P90X) and the poster and fanart for those seasons. (See screenshot below for example.)

However, in the Kodi interface, I get only the "Fitness" show poster fanart, and navigating to the seasons displays neither the poster artwork nor the fanart. Further, it simply lists "Season 1" "Season 2" etc. instead of "P90X", "P90X2", etc.

I have tested in shows without custom season names, and both season poster and season fanart images are displayed in kodi, using my current skin (the default.)

To Reproduce

  1. Create a folder in your library for a new show
  2. Create an .nfo file for this show with appropriate metadata, and mappings for custom season titles using the <namedseason> tag (see included example)
  3. Create season fanart and poster art, following the usual convention of "seasonxx-fanart.jpg" and "seasonxx-poster.jpg"
  4. Add a video file to your season, and re-scan your jellyfin library
  5. Navigate to this show on Jellyfin's web interface, and see that it displays both the correct name and the correct image
  6. Navigate to the show in Kodi's GUI, and see that it displays no artwork (or the show's artwork) and lists only "Season XX"

Expected behavior
Custom season titles should be displayed in Kodi, along with the appropriate season artwork

Logs
I could find no log messages involving this show

Screenshots
Imgur link to example screenshots, with Jellyfin showing correct and Jellyfin-Kodi showing incorrect

System (please complete the following information):
Coreelec 9.2.5 latest) on Odroid C4
Kodi 18.9
Jellyfin 10.6.4 running in linuxserver.io docker container
Jellyfin-Kodi 0.6.5+py2

Additional context
This might be an "enhancement" rather than a bug.

pastebin link to tvshow.nfo for "fitness" metashow

@mcarlton00
Copy link
Member

mcarlton00 commented Nov 28, 2020

The names aren't something we can change. It's a limitation in Kodi itself, it just doesn't support named seasons.

Season images should (and in my experience, do) work properly. All of my season images are set as the Primary image for that season in Jellyfin. If the images are set to a different field then we may not be pulling it down or assigning it because we expect the primary image to be what's used.

*Edit to add: I've also seen reports of some skins not supporting season images, while others do

@TheFeshy
Copy link
Author

Kodi supports named seasons - in fact, this particular folder used to be part of a kodi-only install, and worked properly in kodi. So it works in Kodi, and works in Jellyfin, but does not work in Jellyfin-kodi.

Now, whether named seasons are supported in the kodi API, that might be a different matter. I've only changed it via .nfo files. It might be that this isn't something Kodi allows add-ons to do. If not, let me know and I'll go file a feature request over there!

It looks like almost all of the seasons have the artwork set as the primary image as well - this indeed works on other shows that do not attempt to rename the season, but not on this show with renamed seasons. Custom artwork for individual episodes works as expected, even with the renamed seasons. E.g. going to Season 100, and moving the cursor to episode 100x01 shows the poster assigned to episode 100x0. But the fanart remains the one set for the show, not the season, and selecting the season gives the show fanart, and a generic folder icon for the season.

@mcarlton00
Copy link
Member

That must be a relatively new feature. Every time I've looked into it in the past I was told it wasn't possible.

What's supported or not supported in the Kodi API at this moment doesn't matter, because we don't use it. We interface with the database directly. They frown rather strongly on this and are quick to bring up that we're doing things wrong whenever an issue gets raised related to this addon. I can't blame them, we are doing it wrong, but there's not a better method available to us. We've been investigating other options in #409, but it's not going particularly well.

Asking the Kodi folks for add-ons to be able to modify this will either result in a short answer of "no" or a long answer of "wait for MediaImport". They historically don't like addons being able to change the database.

So all that being said, the most likely reason this isn't working as expected is because we're still assuming that everything is hardcoded to Season XX instead of being able to have custom names. Whether this gets looked at before or after we find another library method that has better overall results, it's hard to say

@mcarlton00 mcarlton00 added the enhancement New feature or request label Nov 28, 2020
@TheFeshy
Copy link
Author

Ah, all right. So good news is, no need to worry about the API because you're already doing the "wrong thing" and writing directly to the db - so it wouldn't be a difficult change. Bad news is, if there is any progress on a "right way" to do things, even a relatively easy change won't be worked on because it would all have to be rewritten anyway.

Good to know; thanks.

@mcarlton00
Copy link
Member

Additional note here: There's a separate issue about season images not working, but so far I still haven't been able to replicate the issue. #342

@mcarlton00
Copy link
Member

Update: From a fresh library sync named seasons do currently appear to be working correctly, but they appear to not get updated when it's already been synced and the server updates them. I'm not sure if this is a matter of the changes not getting pushed to us via the websocket or if we don't have code to handle that metadata change yet

@TheFeshy
Copy link
Author

I was able to get this to work by setting the season name and number via the Jellyfin interface. I also have these set in the .nfo files (tvshow.nfo and season.nfo), and I haven't tested to see if that's necessary or not.

Season artwork also works, but only within the main list. That is, in my original example, if I am in the "fitness" folder I see the individual season artworks if I select a season. Once I enter a season to bring up that season's episode list, it reverts to the show fan art.

That works great for my use case; glad to see I can use this feature again! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants