Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Special episodes with Display order: Absolute #91

Open
winterbird-code opened this issue Aug 6, 2023 · 0 comments
Open

Support for Special episodes with Display order: Absolute #91

winterbird-code opened this issue Aug 6, 2023 · 0 comments

Comments

@winterbird-code
Copy link

It seems this plugin doesn't support special episodes when Display order is set to Absolute.

For example I have Detective Conan in my library configured with Absolute numbering, but when I tried to add a special (for example S0E04 - OVA 01: Conan vs. KID vs. Yaiba it gets the wrong metadata. It does show up as a Special, which is great, but the metadata information on the episode is from Episode 4 - The Coded Map of the City Case, which is less great.
winterbird-code pushed a commit to winterbird-code/jellyfin-plugin-tvdb that referenced this issue Aug 6, 2023
Fix jellyfin#91 - Support for Special episodes with Display order: Ab…
4a3adff 
…solute
@winterbird-code winterbird-code mentioned this issue Aug 12, 2023
Open
scampower3 added a commit to scampower3/jellyfin-plugin-tvdb that referenced this issue Aug 13, 2023
@scampower3
Added PR jellyfin#91 fix
3e43a2d
@winterbird-code winterbird-code mentioned this issue Jan 4, 2024
Merged
crobibero pushed a commit that referenced this issue Feb 11, 2024
@scampower3
Tvdb v4 migration (#93)
1b6930b 
* Start migration to TVDB v4 api

* Incomplete migration

* Migration P2

* Migration push Part 3. Used my fork of TVDbSharper

* Migration Part 4

* Bug fixes

* Done Migration

* Removed redundant searchbyremoteid function

* Fixed Incorrect retrieval of episodeId

* Updated to use a more reliable way of converting ISO 639-2 to ISO 639-1

* Fixed TvdbSeriesProvider

* Fixed actors info and removed unneeded GetImages

* Removed unneeded api calls when getting season and series images.

* Changed to just convert from ISO 639-1 to ISO 639-2

* Switched to use GetCultureInfo instead of constructing

* TvdbMissingEpisodeProvider is now working some of the times

* Fixed TvdbMissingEpisodeProvider to work properly

* Remove some unneeded Api calls

* Added Content Rating retrieval

* Fixed missing season number for absolute in GetEpisodeTvdbId

* Added PR #91 fix

* Added suggested changes

* Add TvdbCultureInfo. Dupe of iso6382.txt from Jellyfin repo

* Added Country info

* Preliminary switch to tvdb-sdk-csharp

* Fixed csproj grouping

* Fixed login bug

* Re-add check for AverageRuntime for null

* Removed  maxSeasonNumber  in TvdbSeriesProvider

* Update to tvdb-sdk-csharp to 4.7.9

* Change to Tvdb.Sdk.dll

* Fixes series.AirDays assignment

* Comments

* Added Suggested changes and removed commented out code

* Removed IsValidEpisode function

* Refactor to use HttpClientFactory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@winterbird-code