From 2b71524c4f0b7df000527feb2a0619c93ffeaf90 Mon Sep 17 00:00:00 2001 From: SenorSmartyPants Date: Sat, 19 Nov 2022 19:14:31 -0600 Subject: [PATCH 1/3] Make Height editable on TV Channels --- src/components/metadataEditor/metadataEditor.js | 9 +++++++++ .../metadataEditor/metadataEditor.template.html | 4 ++++ src/strings/en-us.json | 2 ++ 3 files changed, 15 insertions(+) diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index b1c9d721b3d..8dbb103355a 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -153,6 +153,7 @@ function onSubmit(e) { DateCreated: getDateValue(form, '#txtDateAdded', 'DateCreated'), EndDate: getDateValue(form, '#txtEndDate', 'EndDate'), ProductionYear: form.querySelector('#txtProductionYear').value, + Height: form.querySelector('#txtHeight').value, AspectRatio: form.querySelector('#txtOriginalAspectRatio').value, Video3DFormat: form.querySelector('#select3dFormat').value, @@ -650,6 +651,12 @@ function setFieldVisibilities(context, item) { hideElement('#fldPlaceOfBirth'); } + if (item.MediaType === 'Video' && item.Type === 'TvChannel') { + showElement('#fldHeight'); + } else { + hideElement('#fldHeight'); + } + if (item.MediaType === 'Video' && item.Type !== 'TvChannel') { showElement('#fldOriginalAspectRatio'); } else { @@ -828,6 +835,8 @@ function fillItemInfo(context, item, parentalRatingOptions) { const placeofBirth = item.ProductionLocations?.length ? item.ProductionLocations[0] : ''; context.querySelector('#txtPlaceOfBirth').value = placeofBirth; + context.querySelector('#txtHeight').value = item.Height || ''; + context.querySelector('#txtOriginalAspectRatio').value = item.AspectRatio || ''; context.querySelector('#selectLanguage').value = item.PreferredMetadataLanguage || ''; diff --git a/src/components/metadataEditor/metadataEditor.template.html b/src/components/metadataEditor/metadataEditor.template.html index ce769bbba75..f56acb73f1f 100644 --- a/src/components/metadataEditor/metadataEditor.template.html +++ b/src/components/metadataEditor/metadataEditor.template.html @@ -142,6 +142,10 @@

+
+ +
${ChannelHeightHelp}
+
diff --git a/src/strings/en-us.json b/src/strings/en-us.json index bde44f6886c..c2af8908185 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -134,6 +134,7 @@ "Categories": "Categories", "ChangingMetadataImageSettingsNewContent": "Changes to metadata or artwork downloading settings will only apply to new content added to your library. To apply the changes to existing titles, you'll need to refresh their metadata manually.", "ChannelAccessHelp": "Select the channels to share with this user. Administrators will be able to edit all channels using the metadata manager.", + "ChannelHeightHelp": "Set height of video received on this channel. 720 or greater will mark this channel as HD.", "ChannelNameOnly": "Channel {0} only", "ChannelNumber": "Channel number", "Channels": "Channels", @@ -648,6 +649,7 @@ "LabelHardwareAccelerationType": "Hardware acceleration", "LabelHardwareAccelerationTypeHelp": "Hardware acceleration requires additional configuration.", "LabelHardwareEncoding": "Hardware encoding", + "LabelHeight": "Height", "LabelHomeNetworkQuality": "Home network quality", "LabelHomeScreenSectionValue": "Home screen section {0}", "LabelHttpsPort": "Local HTTPS port number", From 420ff05d916cb07fed41adcaf799cb7baa396e54 Mon Sep 17 00:00:00 2001 From: SenorSmartyPants Date: Thu, 30 Mar 2023 13:43:49 -0500 Subject: [PATCH 2/3] Add dropdown with common broadcast video heights --- src/components/metadataEditor/metadataEditor.js | 4 ++-- .../metadataEditor/metadataEditor.template.html | 11 +++++++++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index 8dbb103355a..c3c50688fc6 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -153,7 +153,7 @@ function onSubmit(e) { DateCreated: getDateValue(form, '#txtDateAdded', 'DateCreated'), EndDate: getDateValue(form, '#txtEndDate', 'EndDate'), ProductionYear: form.querySelector('#txtProductionYear').value, - Height: form.querySelector('#txtHeight').value, + Height: form.querySelector('#selectHeight').value, AspectRatio: form.querySelector('#txtOriginalAspectRatio').value, Video3DFormat: form.querySelector('#select3dFormat').value, @@ -835,7 +835,7 @@ function fillItemInfo(context, item, parentalRatingOptions) { const placeofBirth = item.ProductionLocations?.length ? item.ProductionLocations[0] : ''; context.querySelector('#txtPlaceOfBirth').value = placeofBirth; - context.querySelector('#txtHeight').value = item.Height || ''; + context.querySelector('#selectHeight').value = item.Height || ''; context.querySelector('#txtOriginalAspectRatio').value = item.AspectRatio || ''; diff --git a/src/components/metadataEditor/metadataEditor.template.html b/src/components/metadataEditor/metadataEditor.template.html index f56acb73f1f..7f7acd7e3d1 100644 --- a/src/components/metadataEditor/metadataEditor.template.html +++ b/src/components/metadataEditor/metadataEditor.template.html @@ -142,8 +142,15 @@

-
- +
+
${ChannelHeightHelp}
From 8443b5d6db5e3836bfc2b7a231962428cd072b44 Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Tue, 5 Mar 2024 02:31:53 -0500 Subject: [PATCH 3/3] Update channel resolution setting text --- .../metadataEditor/metadataEditor.template.html | 13 ++++++------- src/strings/en-us.json | 7 +++++-- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/components/metadataEditor/metadataEditor.template.html b/src/components/metadataEditor/metadataEditor.template.html index 7f7acd7e3d1..6c01c2fc070 100644 --- a/src/components/metadataEditor/metadataEditor.template.html +++ b/src/components/metadataEditor/metadataEditor.template.html @@ -143,15 +143,14 @@

- - - - - - + + + + + -
${ChannelHeightHelp}
diff --git a/src/strings/en-us.json b/src/strings/en-us.json index c2af8908185..7bc81572d49 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -134,7 +134,11 @@ "Categories": "Categories", "ChangingMetadataImageSettingsNewContent": "Changes to metadata or artwork downloading settings will only apply to new content added to your library. To apply the changes to existing titles, you'll need to refresh their metadata manually.", "ChannelAccessHelp": "Select the channels to share with this user. Administrators will be able to edit all channels using the metadata manager.", - "ChannelHeightHelp": "Set height of video received on this channel. 720 or greater will mark this channel as HD.", + "ChannelResolutionSD": "SD", + "ChannelResolutionSDPAL": "SD (PAL)", + "ChannelResolutionHD": "HD", + "ChannelResolutionFullHD": "Full HD", + "ChannelResolutionUHD4K": "UHD (4K)", "ChannelNameOnly": "Channel {0} only", "ChannelNumber": "Channel number", "Channels": "Channels", @@ -649,7 +653,6 @@ "LabelHardwareAccelerationType": "Hardware acceleration", "LabelHardwareAccelerationTypeHelp": "Hardware acceleration requires additional configuration.", "LabelHardwareEncoding": "Hardware encoding", - "LabelHeight": "Height", "LabelHomeNetworkQuality": "Home network quality", "LabelHomeScreenSectionValue": "Home screen section {0}", "LabelHttpsPort": "Local HTTPS port number",