From 29ff7ce9e962787e7afa450b8bbc4a69e49850d7 Mon Sep 17 00:00:00 2001 From: felix920506 Date: Wed, 27 Nov 2024 10:01:08 -0500 Subject: [PATCH 1/4] make tonemapping helptext make sense --- src/strings/en-us.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/strings/en-us.json b/src/strings/en-us.json index 9dd8f84b44f..5a53ba88e09 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -955,14 +955,14 @@ "LabelTitle": "Title", "LabelTonemappingAlgorithm": "Select the Tone mapping algorithm to use", "LabelTonemappingDesat": "Tone mapping desat", - "LabelTonemappingDesatHelp": "Apply desaturation for highlights that exceed this level of brightness. The higher the parameter, the more color information will be preserved. This setting helps prevent unnaturally blown-out colors for super-highlights, by (smoothly) turning into white instead. This makes images feel more natural, at the cost of reducing information about out-of-range colors. The recommended and default values are 0 and 0.5.", + "LabelTonemappingDesatHelp": "Apply desaturation for highlights that exceed this level of brightness. The higher the parameter, the more color information will be preserved. This setting helps prevent unnaturally blown-out colors for super-highlights, by (smoothly) turning into white instead. This makes images feel more natural, at the cost of reducing information about out-of-range colors. The recommended value is 0.", "LabelTonemappingParam": "Tone mapping param", "LabelTonemappingParamHelp": "Tune the tone mapping algorithm. The recommended and default values are NaN. Generally leave it blank.", "LabelTonemappingPeak": "Tone mapping peak", - "LabelTonemappingPeakHelp": "Override signal/nominal/reference peak with this value. Useful when the embedded peak information in display metadata is not reliable or when tone mapping from a lower range to a higher range. The recommended and default values are 100 and 0.", + "LabelTonemappingPeakHelp": "Override signal/nominal/reference peak with this value. Useful when the embedded peak information in display metadata is not reliable or when tone mapping from a lower range to a higher range. The recommended value is 100.", "LabelTonemappingRange": "Tone mapping range", "LabelTonemappingThreshold": "Tone mapping threshold", - "LabelTonemappingThresholdHelp": "The tone mapping algorithm parameters is fine-tuned per each scene. And a threshold is used to detect whether the scene has changed or not. If the distance between the current frame average brightness and the current running average exceeds a threshold value, we would re-calculate scene average and peak brightness. The recommended and default values are 0.8 and 0.2.", + "LabelTonemappingThresholdHelp": "The tone mapping algorithm parameters is fine-tuned per each scene. And a threshold is used to detect whether the scene has changed or not. If the distance between the current frame average brightness and the current running average exceeds a threshold value, we would re-calculate scene average and peak brightness. The recommended value is 0.8.", "LabelTrackNumber": "Track number", "LabelTranscodePath": "Transcode path", "LabelTranscodes": "Transcodes", @@ -1739,9 +1739,9 @@ "EnableEnhancedNvdecDecoderHelp": "Enhanced NVDEC implementation, disable this option to use CUVID if you encounter decoding errors.", "EnableSplashScreen": "Enable the splash screen", "LabelVppTonemappingBrightness": "VPP Tone mapping brightness gain", - "LabelVppTonemappingBrightnessHelp": "Apply brightness gain in VPP tone mapping. The recommended and default values are 16 and 0.", + "LabelVppTonemappingBrightnessHelp": "Apply brightness gain in VPP tone mapping. The recommended value is 16.", "LabelVppTonemappingContrast": "VPP Tone mapping contrast gain", - "LabelVppTonemappingContrastHelp": "Apply contrast gain in VPP tone mapping. Both recommended and default values are 1.", + "LabelVppTonemappingContrastHelp": "Apply contrast gain in VPP tone mapping. The recommended value is 1.", "VideoRangeTypeNotSupported": "The video's range type is not supported", "LabelVideoRangeType": "Video range type", "MediaInfoVideoRangeType": "Video range type", From 805d068365ec0220c99e5156daf3fd2282afa8ec Mon Sep 17 00:00:00 2001 From: felix920506 Date: Sat, 14 Dec 2024 13:42:44 -0500 Subject: [PATCH 2/4] Remove unused string according to feedback --- src/strings/en-us.json | 1 - 1 file changed, 1 deletion(-) diff --git a/src/strings/en-us.json b/src/strings/en-us.json index 5a53ba88e09..23f5b18115b 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -962,7 +962,6 @@ "LabelTonemappingPeakHelp": "Override signal/nominal/reference peak with this value. Useful when the embedded peak information in display metadata is not reliable or when tone mapping from a lower range to a higher range. The recommended value is 100.", "LabelTonemappingRange": "Tone mapping range", "LabelTonemappingThreshold": "Tone mapping threshold", - "LabelTonemappingThresholdHelp": "The tone mapping algorithm parameters is fine-tuned per each scene. And a threshold is used to detect whether the scene has changed or not. If the distance between the current frame average brightness and the current running average exceeds a threshold value, we would re-calculate scene average and peak brightness. The recommended value is 0.8.", "LabelTrackNumber": "Track number", "LabelTranscodePath": "Transcode path", "LabelTranscodes": "Transcodes", From bd8f8a2ebd6452504b9fb7309f4f7e79da2a2299 Mon Sep 17 00:00:00 2001 From: felix920506 Date: Mon, 23 Dec 2024 11:58:13 +0800 Subject: [PATCH 3/4] suggestion from review Co-authored-by: gnattu --- src/strings/en-us.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/strings/en-us.json b/src/strings/en-us.json index 23f5b18115b..60ae395269a 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -959,7 +959,7 @@ "LabelTonemappingParam": "Tone mapping param", "LabelTonemappingParamHelp": "Tune the tone mapping algorithm. The recommended and default values are NaN. Generally leave it blank.", "LabelTonemappingPeak": "Tone mapping peak", - "LabelTonemappingPeakHelp": "Override signal/nominal/reference peak with this value. Useful when the embedded peak information in display metadata is not reliable or when tone mapping from a lower range to a higher range. The recommended value is 100.", + "LabelTonemappingPeakHelp": "Override the embedded metadata value for the input signal with this peak value instead. The default value is 100 (1000nit).", "LabelTonemappingRange": "Tone mapping range", "LabelTonemappingThreshold": "Tone mapping threshold", "LabelTrackNumber": "Track number", From 2a58804304db841e35363d77f2c224605d68fb45 Mon Sep 17 00:00:00 2001 From: felix920506 Date: Mon, 23 Dec 2024 11:59:59 +0800 Subject: [PATCH 4/4] apply suggestion --- src/strings/en-us.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/strings/en-us.json b/src/strings/en-us.json index 60ae395269a..c1a874d4020 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -955,7 +955,7 @@ "LabelTitle": "Title", "LabelTonemappingAlgorithm": "Select the Tone mapping algorithm to use", "LabelTonemappingDesat": "Tone mapping desat", - "LabelTonemappingDesatHelp": "Apply desaturation for highlights that exceed this level of brightness. The higher the parameter, the more color information will be preserved. This setting helps prevent unnaturally blown-out colors for super-highlights, by (smoothly) turning into white instead. This makes images feel more natural, at the cost of reducing information about out-of-range colors. The recommended value is 0.", + "LabelTonemappingDesatHelp": "Apply desaturation for highlights that exceed this level of brightness. The recommended value is 0 (disable).", "LabelTonemappingParam": "Tone mapping param", "LabelTonemappingParamHelp": "Tune the tone mapping algorithm. The recommended and default values are NaN. Generally leave it blank.", "LabelTonemappingPeak": "Tone mapping peak",