Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Maven properties #851

Open
basil opened this issue Apr 26, 2024 · 7 comments · May be fixed by jenkinsci/winp#138
Open

Custom Maven properties #851

basil opened this issue Apr 26, 2024 · 7 comments · May be fixed by jenkinsci/winp#138

Comments

@basil
Copy link
Contributor

basil commented Apr 26, 2024

What feature do you want to see added?

In https://github.com/jenkinsci/winp I would like to have a Matrix build where one configuration uses native.configuration=Release and another uses native.configuration=Debug. Right now I can customize jenkins.version per parallel branch, but not other Maven properties. It would nice to be able to pass in arbitrary Maven properties. I could of course copy and paste the entire buildPlugin() step into that repository, but that would not be good from the perspective of code reuse.

Upstream changes

No response

@biru-codeastromer
Copy link

Hi @basil , I have raised a PR for this issue in the winp repo #138 .
Please do check and review and let me know if it solves your issue here. Thanks !

@dduportal
Copy link
Contributor

Hi @basil , I have raised a PR for this issue in the winp repo #138 . Please do check and review and let me know if it solves your issue here. Thanks !

The issue is in this repository for a reason: it has to be in the buildPlugin() function. See my comment in jenkinsci/winp#138 (review)

@biru-codeastromer
Copy link

biru-codeastromer commented Feb 17, 2025

The issue is in this repository for a reason: it has to be in the buildPlugin() function. See my comment in jenkinsci/winp#138 (review)

Got it !
Thanks for the clarification ! I will surely implement the changes in the buildPlugin() function and raise a PR soon here.
I will update you about that.

@dduportal
Copy link
Contributor

The issue is in this repository for a reason: it has to be in the buildPlugin() function. See my comment in jenkinsci/winp#138 (review)

Got it ! Thanks for the clarification ! I will surely implement the changes in the buildPlugin() function and raise a PR soon here. I will update you about that.

Given the impact it could have, you should not plan and expect anything on this before middle March.

@biru-codeastromer
Copy link

biru-codeastromer commented Feb 17, 2025

Given the impact it could have, you should not plan and expect anything on this before middle March.

So , it will be better for me to not create a PR as of now for this right and wait for mid-March to have the requirement done ?

@dduportal
Copy link
Contributor

Given the impact it could have, you should not plan and expect anything on this before middle March.

So , it will be better for me to not create a PR as of now for this right and wait for mid-March to have the requirement done ?

Yes, I recommend this

@biru-codeastromer
Copy link

Thanks ! I will wait till mid - March to get your confirmation before working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants