From 1b4f66288cadf0f0dfbc87c17360fa05e2d07cad Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 03:01:58 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- .../java/org/jenkinsci/plugins/ios/connector/iOSDevice.java | 3 ++- .../org/jenkinsci/plugins/ios/connector/iOSDeviceList.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDevice.java b/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDevice.java index c2c5d78..4517b27 100644 --- a/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDevice.java +++ b/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDevice.java @@ -14,6 +14,7 @@ import java.io.IOException; import java.io.Serializable; import java.io.StringWriter; +import java.nio.file.Files; import java.util.Properties; /** @@ -84,7 +85,7 @@ public void deploy(File bundle, TaskListener listener) throws IOException, Inter public HttpResponse doDoDeploy(StaplerRequest req) throws IOException { // The web interface can only support uploading self-contained .ipa files, // not .app directory bundles, so give the temporary file a .ipa suffix - File f = File.createTempFile("jenkins",".ipa"); + File f = Files.createTempFile("jenkins", ".ipa").toFile(); StringWriter w = new StringWriter(); try { req.getFileItem("ipa").write(f); diff --git a/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDeviceList.java b/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDeviceList.java index 61c2c98..c4183f8 100644 --- a/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDeviceList.java +++ b/src/main/java/org/jenkinsci/plugins/ios/connector/iOSDeviceList.java @@ -28,6 +28,7 @@ import java.io.IOException; import java.io.InputStreamReader; import java.io.PrintStream; +import java.nio.file.Files; import java.util.Collections; import java.util.List; import java.util.Map; @@ -163,7 +164,7 @@ public List call() throws IOException { if (!Platform.isMac()) return Collections.emptyList(); - File exe = File.createTempFile("ios","list"); + File exe = Files.createTempFile("ios", "list").toFile(); try { PrintStream logger = listener.getLogger(); logger.println("Listing up iOS Devices");