Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing disabled jobs with checkbox unchecked #726

Closed
dchesterman opened this issue Jan 21, 2025 · 1 comment · Fixed by #727
Closed

Processing disabled jobs with checkbox unchecked #726

dchesterman opened this issue Jan 21, 2025 · 1 comment · Fixed by #727

Comments

@dchesterman
Copy link

Jenkins and plugins versions report

Environment

plugin version 795.v995762102f28

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux

Reproduction steps

  1. Under "Manage Jenkins > System" leave "Process disabled jobs" unchecked.
  2. Disable a Job
  3. Job Metrics still appear at prometheus endpoint

Expected Results

Job metrics for disabled jobs should not be collected?

Actual Results

Job metrics are collected

Anything else?

Is this line backwards?

https://github.com/jenkinsci/prometheus-plugin/blob/master/src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java#L160

Should it be !processDisabledJobs or am I misunderstanding the feature?

Are you interested in contributing a fix?

No response

@Waschndolos
Copy link

From my first look into it you could be right yeah. I'll check. Good catch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants