Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultLocale overridden by first language code #90

Open
k2s opened this issue Jan 22, 2016 · 3 comments
Open

defaultLocale overridden by first language code #90

k2s opened this issue Jan 22, 2016 · 3 comments

Comments

@k2s
Copy link

k2s commented Jan 22, 2016

configuration option defaultLocale is always overridden by first language code

var localeConfig = {
    langs: {
        'en': 'English',
        'sk': 'Slovak'
    },
    defaultLocale: 'sk'
};

i18n.expressBind(app, localeConfig);

value of req.i18n.defaultLocale will be set to en, it should be sk
@SeverS
Copy link

SeverS commented Apr 11, 2016

actually defaultLocale option is not working. it defaults to 'en' no matter what.

@cjduncana
Copy link

I just recently encountered the same problem.

@gjuchault
Copy link
Collaborator

I'll look into this when I have some time

wallali added a commit to wallali/i18n-node-2 that referenced this issue Jun 9, 2017
@wallali
Allow defaultLocale to be supplied with opts. jeresig#90
776de38
@wallali wallali mentioned this issue Jun 9, 2017
Merged
gjuchault pushed a commit that referenced this issue Jun 9, 2017
@wallali @gjuchault
Allow defaultLocale to be supplied with opts. #90 (#105)
28a93b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@k2s @gjuchault @cjduncana @SeverS