New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Hardcoded defaults #7

Open

hawksight opened this issue Nov 19, 2024 · 1 comment

Labels

enhancement help wanted

Member

hawksight commented Nov 19, 2024

Make a list of anything hardcoded
Decide if they need to be configurable - if so raise specific issue

Once happy all essentials are raised, this is done.

hawksight added enhancement help wanted labels

Collaborator

aidy commented Nov 21, 2024

e.g.

terraform-provider-tlspc/internal/provider/certificate_template_resource.go

Lines 121 to 127 in eb28ec9

    
           SANRegexes:       []string{".*"}, 
        
           SubjectCNRegexes: []string{".*"}, 
        
           SubjectCValues:   []string{".*"}, 
        
           SubjectLRegexes:  []string{".*"}, 
        
           SubjectORegexes:  []string{".*"}, 
        
           SubjectOURegexes: []string{".*"}, 
        
           SubjectSTRegexes: []string{".*"},

aidy changed the title ~~Review Hardcoded references~~ Review Hardcoded defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment