Fix popover text selection #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove focus trap as this was causing text selection issues in popover - could not figure out the reason why this was the case. Changed the filter icon to filterList icon
There was a problem hiding this comment.
Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (4)
- package.json: Language not supported
- apps/landing/pages/pricing/index.tsx: Evaluated as low risk
- apps/landing/components/Modal.tsx: Evaluated as low risk
- libs/ui/src/lib/data-table/DataTableRenderers.tsx: Evaluated as low risk
Comments suppressed due to low confidence (3)
libs/ui/src/lib/sobject-list/SobjectListFilter.tsx:225
- [nitpick] The icon name 'filterList' should be checked for consistency with other parts of the application to ensure it matches the intended design.
icon="filterList"
libs/ui/src/lib/sobject-field-list/SobjectFieldListFilter.tsx:169
- [nitpick] The class name 'slds-button__icon' replaces 'slds-button__icon_large'. Ensure this change does not affect the intended icon size.
<Icon type="utility" icon="filterList" description="Open filters menu" className="slds-button__icon" omitContainer />
libs/ui/src/lib/form/context-menu/ContextMenu.tsx:147
- Verify that replacing
FocusTrapwithFocusScopedoes not introduce any new issues, especially related to focus management and text selection.
<FocusScope contain restoreFocus autoFocus>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove focus trap as this was causing text selection issues in popover - could not figure out the reason why this was the case.
Changed the filter icon to filterList icon