Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Disabled tests in core #12396

Open
28 of 39 tasks
janbartel opened this issue Oct 16, 2024 · 16 comments
Open
28 of 39 tasks

Review Disabled tests in core #12396

janbartel opened this issue Oct 16, 2024 · 16 comments
Assignees
@olamy @gregw @joakime @janbartel @sbordet @lorban @lachlan-roberts
Labels
Task

Comments

@janbartel
Copy link
Contributor

janbartel commented Oct 16, 2024 •
edited
Loading

Jetty version(s)
12.1.x

Jetty Environment
core

Review the following test classes that have at least one @Disabled test. Acceptable resolutions are:

  • reinstate test (remove @Disabled)
  • delete test
  • add comment to @Disabled and add any @EnabledOn, @DisabledOn as necessary to circumscribe test
  • jetty-http/src/test/java/org/eclipse/jetty/http/MultiPartFormDataTest.java
  • jetty-http/src/test/java/org/eclipse/jetty/http/MultiPartTest.java
  • jetty-http2/jetty-http2-tests/src/test/java/org/eclipse/jetty/http2/tests/AsyncServletTest.java
  • jetty-http2/jetty-http2-tests/src/test/java/org/eclipse/jetty/http2/tests/MaxConcurrentStreamsTest.java
  • jetty-http2/jetty-http2-tests/src/test/java/org/eclipse/jetty/http2/tests/ConcurrentStreamCreationTest.java
  • jetty-http2/jetty-http2-tests/src/test/java/org/eclipse/jetty/http2/tests/AsyncIOTest.java
  • jetty-client/src/test/java/org/eclipse/jetty/client/HttpClientTLSTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/ShutdownMonitorTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SniSslConnectionFactoryTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/PartialRFC2616Test.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/NotAcceptingTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/HttpConnectionTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/HttpChannelEventTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/QoSHandlerTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/NcsaRequestLogTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/SecuredRedirectHandlerCodeTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/ContextHandlerGetResourceTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/ResourceHandlerTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/ContextHandlerTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/DebugHandlerTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/ResourceHandlerByteRangesTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/handler/AllowSymLinkAliasCheckerTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/ServerConnectorTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/ThreadStarvationTest.java
  • jetty-server/src/test/java/org/eclipse/jetty/server/LowResourcesMonitorTest.java
  • jetty-quic/jetty-quic-server/src/test/java/org/eclipse/jetty/quic/server/QuicServerConnectorTest.java
  • jetty-util/src/test/java/org/eclipse/jetty/util/resource/MountedPathResourceTest.java
  • jetty-util/src/test/java/org/eclipse/jetty/util/resource/ResourceFactoryTest.java
  • jetty-util/src/test/java/org/eclipse/jetty/util/resource/ResourceTest.java
  • jetty-util/src/test/java/org/eclipse/jetty/util/ssl/SslContextFactoryTest.java
  • jetty-util/src/test/java/org/eclipse/jetty/util/thread/VirtualThreadPoolTest.java
  • jetty-security/src/test/java/org/eclipse/jetty/security/SPNEGOAuthenticatorTest.java
  • jetty-fcgi/jetty-fcgi-server/src/test/java/org/eclipse/jetty/fcgi/server/ExternalFastCGIServerTest.java
  • jetty-websocket/jetty-websocket-core-tests/src/test/java/org/eclipse/jetty/websocket/core/autobahn/AutobahnTests.java
  • jetty-tests/jetty-test-client-transports/src/test/java/org/eclipse/jetty/test/client/transport/VirtualThreadsTest.java
  • jetty-http3/jetty-http3-tests/src/test/java/org/eclipse/jetty/http3/tests/HandlerClientServerTest.java
  • jetty-http3/jetty-http3-qpack/src/test/java/org/eclipse/jetty/http3/qpack/EncodeDecodeTest.java
  • jetty-alpn/jetty-alpn-conscrypt-client/src/test/java/org/eclipse/jetty/alpn/java/client/ConscryptHTTP2ClientTest.java
  • jetty-alpn/jetty-alpn-conscrypt-server/src/test/java/org/eclipse/jetty/alpn/conscrypt/server/ConscryptHTTP2ServerTest.java
@janbartel janbartel added the Task label Oct 16, 2024
@janbartel
Copy link
Contributor Author

ShutdownMonitorTest see PR #12398

@olamy
Copy link
Member

olamy commented Oct 17, 2024

conscrypt test are disabled for aarch64 only because of google/conscrypt#1051

olamy added a commit that referenced this issue Oct 17, 2024
@olamy
Issue #12396 enable back ResourceFactoryTest
03505df 
Signed-off-by: Olivier Lamy <[email protected]>
@olamy
Copy link
Member

olamy commented Oct 17, 2024

ResourcceFactoryTest #12402

olamy added a commit that referenced this issue Oct 19, 2024
@olamy
Merge pull request #12402 from jetty/jetty-12.1.x-resource-factory-te…
806f068 
…st-enabled

Issue #12396 enable back ResourceFactoryTest
@janbartel
Copy link
Contributor Author

ContextHandlerGetResourceTest and AllowSymLinkAliasCheckerTest #12412

@gregw gregw linked a pull request Oct 22, 2024 that will close this issue
Implement RFC8187 filenames for Content-Disposition in MultiPart #12413
Merged
@gregw gregw mentioned this issue Oct 22, 2024
Merged
@gregw gregw removed a link to a pull request Oct 22, 2024
Implement RFC8187 filenames for Content-Disposition in MultiPart #12413
Merged
@janbartel
Copy link
Contributor Author

MountedPathResourceTest reviewed, and relevant JDK bug is still unresolved (see https://bugs.openjdk.org/browse/JDK-8311079) so keeping @Disabled.

olamy added a commit that referenced this issue Oct 23, 2024
@olamy
Issue #12396 remove non reliable test from LowResourcesMonitorTest
319b9c1 
Signed-off-by: Olivier Lamy <[email protected]>
@olamy
Copy link
Member

olamy commented Oct 23, 2024

LowResourcesMonitorTest PR #12417

@janbartel
Copy link
Contributor Author

ResourceHandlerTest see #12418

@janbartel
Copy link
Contributor Author

ResourceHandlerByteRangesTest see #12419

lachlan-roberts added a commit that referenced this issue Oct 23, 2024
@lachlan-roberts
Issue #12396 - fix and re-enable NcsaRequestLogTest
a2f02ce 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Oct 23, 2024
Merged
@joakime
Copy link
Contributor

joakime commented Oct 23, 2024

DebugHandlerTest see #12424

lachlan-roberts added a commit that referenced this issue Oct 24, 2024
@lachlan-roberts
Merge pull request #12420 from jetty/jetty-12.1.x-12396-NcsaRequestLo…
2d9ef61 
…gTest

Issue #12396 - fix and re-enable NcsaRequestLogTest
lachlan-roberts added a commit that referenced this issue Oct 24, 2024
@lachlan-roberts
Issue #12396 - remove QPACK EncodeDecodeTest
f9cd723 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Oct 24, 2024
Merged
lachlan-roberts added a commit that referenced this issue Oct 28, 2024
@lachlan-roberts
Merge pull request #12426 from jetty/jetty-12.1.x-12396-QPACK-EncodeD…
5df425b 
…ecodeTest

Issue #12396 - remove QPACK EncodeDecodeTest
olamy added a commit that referenced this issue Oct 28, 2024
@olamy
Issue #12396 remove non reliable test from LowResourcesMonitorTest (#…
465e0ac 
…12417)

Signed-off-by: Olivier Lamy <[email protected]>
janbartel added a commit that referenced this issue Oct 31, 2024
@janbartel
Issue #12396 remove disabled test in ContextHandlerTest
08653c8
@janbartel
Copy link
Contributor Author

ContextHandlerTest PR #12450

@janbartel
Copy link
Contributor Author

NotAcceptingTest see PR #12451

janbartel added a commit that referenced this issue Nov 1, 2024
@janbartel
Jetty 12.1.x fix context handler test (#12450)
e3495ff 
* Issue #12396 remove disabled test in ContextHandlerTest
@janbartel
Copy link
Contributor Author

jetty-12.1.x-undisable-SecuredRedirectHandlerCodeTest see PR #12471

@janbartel
Copy link
Contributor Author

HttpConnectionTest see PR #12472

@janbartel
Copy link
Contributor Author

HttpChannelEventTest see PR #12477

@janbartel
Copy link
Contributor Author

PartialRFC2616Test see #12486

@janbartel
Copy link
Contributor Author

ExternalFastCGITest see #12487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olamy olamy

@gregw gregw

@joakime joakime

@janbartel janbartel

@sbordet sbordet

@lorban lorban

@lachlan-roberts lachlan-roberts

Labels
Task
Projects
Jetty 12.1.0
Status: No status
Milestone
No milestone
Development

No branches or pull requests
7 participants
@olamy @gregw @joakime @janbartel @sbordet @lorban @lachlan-roberts